jenkins-bot has submitted this change and it was merged. Change subject: jquery.payment: don't express dependency on jQuery ......................................................................
jquery.payment: don't express dependency on jQuery jQuery is a dependency for ResourceLoader itself, so you can be sure it has always already been loaded. If you try to express a dependency on it explicitly, a test in core will fail: 26) ResourcesTest::testDependencies Module 'jquery.payment' must not depend on 'jquery' Failed asserting that an array does not contain 'jquery'. in tests/phpunit/structure/ResourcesTest.php:50 Change-Id: I550d89e94550e45e72200152d9316f8b01541b2e --- M DonationInterface.php 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Awight: Looks good to me, approved jenkins-bot: Verified diff --git a/DonationInterface.php b/DonationInterface.php index c5aa0b8..20c4ca9 100644 --- a/DonationInterface.php +++ b/DonationInterface.php @@ -921,7 +921,6 @@ $wgResourceModules['jquery.payment'] = array( 'scripts' => 'jquery.payment/jquery.payment.js', - 'dependencies' => array( 'jquery' ) ) + $wgResourceTemplate;; // load any rapidhtml related resources -- To view, visit https://gerrit.wikimedia.org/r/142888 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I550d89e94550e45e72200152d9316f8b01541b2e Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/DonationInterface Gerrit-Branch: deploy-payments_1.22 Gerrit-Owner: Awight <awi...@wikimedia.org> Gerrit-Reviewer: Awight <awi...@wikimedia.org> Gerrit-Reviewer: Ejegg <eeggles...@wikimedia.org> Gerrit-Reviewer: Mwalker <mwal...@wikimedia.org> Gerrit-Reviewer: Ori.livneh <o...@wikimedia.org> Gerrit-Reviewer: Ssmith <ssm...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits