Brian Wolff has uploaded a new change for review. https://gerrit.wikimedia.org/r/142976
Change subject: Add unit tests for ffmpeg2theora ogg recognition bug ...................................................................... Add unit tests for ffmpeg2theora ogg recognition bug Change-Id: I2e6944ccff3882b9f9ee1ac5ab6f5fea1de9d353 Follow-up: 629169ce9bd7 --- M tests/phpunit/data/media/README A tests/phpunit/data/media/say-test.ogg M tests/phpunit/includes/MimeMagicTest.php 3 files changed, 13 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/76/142976/1 diff --git a/tests/phpunit/data/media/README b/tests/phpunit/data/media/README index ca132a4..9913f68 100644 --- a/tests/phpunit/data/media/README +++ b/tests/phpunit/data/media/README @@ -55,3 +55,7 @@ https://commons.wikimedia.org/wiki/File:Bishzilla_blink.gif Public domain Bishonen + +say-test.ogg +Public domain +Brian Wolff diff --git a/tests/phpunit/data/media/say-test.ogg b/tests/phpunit/data/media/say-test.ogg new file mode 100644 index 0000000..5d814fb --- /dev/null +++ b/tests/phpunit/data/media/say-test.ogg Binary files differ diff --git a/tests/phpunit/includes/MimeMagicTest.php b/tests/phpunit/includes/MimeMagicTest.php index edc3d6f..6ce6fd8 100644 --- a/tests/phpunit/includes/MimeMagicTest.php +++ b/tests/phpunit/includes/MimeMagicTest.php @@ -36,4 +36,13 @@ ); } + /** + * Test to make sure that encoder=ffmpeg2theora doesn't trigger + * MEDIATYPE_VIDEO (bug 63584) + */ + function testOggRecognize() { + $oggFile = __DIR__ . '/../data/media/say-test.ogg'; + $actualType = $this->mimeMagic->getMediaType( $oggFile, 'application/ogg' ); + $this->assertEquals( $actualType, MEDIATYPE_AUDIO ); + } } -- To view, visit https://gerrit.wikimedia.org/r/142976 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2e6944ccff3882b9f9ee1ac5ab6f5fea1de9d353 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Brian Wolff <bawolff...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
