EBernhardson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/143076
Change subject: Fix constructor typo
......................................................................
Fix constructor typo
The constructor here was never setting $this->workflow, correct
the code so things are initialized properly. This was preventing
the core revision content from containing the related workflowId.
Change-Id: I49ca214ad5e7e9cb7a564ad5746bca67e21d2041
---
M includes/Content/BoardContent.php
M includes/Content/BoardContentHandler.php
2 files changed, 4 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow
refs/changes/76/143076/1
diff --git a/includes/Content/BoardContent.php
b/includes/Content/BoardContent.php
index 2fc4c6b..53c762d 100644
--- a/includes/Content/BoardContent.php
+++ b/includes/Content/BoardContent.php
@@ -32,8 +32,8 @@
}
if (
- $this->workflow instanceof UUID ||
- ( $this->workflow instanceof Workflow && !
$this->workflow->isNew() )
+ $workflow instanceof UUID ||
+ ( $workflow instanceof Workflow && !$workflow->isNew() )
) {
$this->workflow = $workflow;
}
diff --git a/includes/Content/BoardContentHandler.php
b/includes/Content/BoardContentHandler.php
index eaa167d..62e5874 100644
--- a/includes/Content/BoardContentHandler.php
+++ b/includes/Content/BoardContentHandler.php
@@ -51,6 +51,7 @@
*/
public function unserializeContent( $blob, $format = null ) {
$info = FormatJson::decode( $blob, true );
+ $uuid = null;
if ( ! $info ) {
// For transition from wikitext-type pages
@@ -100,4 +101,4 @@
return $output;
}
-}
\ No newline at end of file
+}
--
To view, visit https://gerrit.wikimedia.org/r/143076
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I49ca214ad5e7e9cb7a564ad5746bca67e21d2041
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: EBernhardson <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
