Andrew Bogott has submitted this change and it was merged.
Change subject: dynamicproxy: Let 403 and 404 responses pass through
......................................................................
dynamicproxy: Let 403 and 404 responses pass through
Lighttpd handles these already. In addition, these aren't always
emitted by the file system. Web applications can (should!) use
proper http status codes and should not get their responses
replaced by the proxy. Cf. bug 64393.
Change-Id: Ied73974ce9512d0d9a56389b3ac687ebea8bd03e
---
M modules/dynamicproxy/templates/urlproxy.conf
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Andrew Bogott: Looks good to me, approved
Yuvipanda: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/modules/dynamicproxy/templates/urlproxy.conf
b/modules/dynamicproxy/templates/urlproxy.conf
index dba2baf..8e17e27 100644
--- a/modules/dynamicproxy/templates/urlproxy.conf
+++ b/modules/dynamicproxy/templates/urlproxy.conf
@@ -64,8 +64,8 @@
# We can make this larger if need be.
client_max_body_size 128m;
- error_page 403 /admin/?403;
- error_page 404 /admin/?404;
+ #error_page 403 /admin/?403; # bug 64393
+ #error_page 404 /admin/?404; # bug 64393
error_page 500 /admin/?500;
error_page 502 /admin/?502;
error_page 503 /admin/?503;
--
To view, visit https://gerrit.wikimedia.org/r/143081
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ied73974ce9512d0d9a56389b3ac687ebea8bd03e
Gerrit-PatchSet: 3
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Krinkle <[email protected]>
Gerrit-Reviewer: Andrew Bogott <[email protected]>
Gerrit-Reviewer: Nemo bis <[email protected]>
Gerrit-Reviewer: Yuvipanda <[email protected]>
Gerrit-Reviewer: coren <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
