Zfilipin has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/143603

Change subject: Fixed "no implicit conversion of nil into String (TypeError)"
......................................................................

Fixed "no implicit conversion of nil into String (TypeError)"

This happens if MEDIAWIKI_USER environment variable is not set:

$ bundle exec cucumber
no implicit conversion of nil into String (TypeError)
…tests/browser/features/support/pages/user_page.rb:6:in `+'
…

Change-Id: Id76b4df32f85fa30acacc7641a06eb301f2e9331
---
M tests/browser/features/support/pages/user_page.rb
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow 
refs/changes/03/143603/1

diff --git a/tests/browser/features/support/pages/user_page.rb 
b/tests/browser/features/support/pages/user_page.rb
index cc14a48..baf8b76 100644
--- a/tests/browser/features/support/pages/user_page.rb
+++ b/tests/browser/features/support/pages/user_page.rb
@@ -3,7 +3,7 @@
 
   include URL
   # MEDIAWIKI_URL must have this in $wgFlowOccupyPages array or 
$wgFlowOccupyNamespaces.
-  page_url URL.url("User talk:" + ENV["MEDIAWIKI_USER"])
+  page_url URL.url("User talk:ENV['MEDIAWIKI_USER']")
 
   h1(:first_heading, id: "firstHeading")
 end

-- 
To view, visit https://gerrit.wikimedia.org/r/143603
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id76b4df32f85fa30acacc7641a06eb301f2e9331
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Zfilipin <zfili...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to