Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/144032
Change subject: Change some mixed @param docs in api classes
......................................................................
Change some mixed @param docs in api classes
Change-Id: I2ab4b0ae452325392c4ea72ab3d985107d429ac2
---
M includes/api/ApiBase.php
M includes/api/ApiQueryBase.php
M includes/api/ApiQueryRecentChanges.php
M includes/api/ApiQueryUserContributions.php
4 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/32/144032/1
diff --git a/includes/api/ApiBase.php b/includes/api/ApiBase.php
index d221799..a657317 100644
--- a/includes/api/ApiBase.php
+++ b/includes/api/ApiBase.php
@@ -1189,9 +1189,9 @@
* @param mixed $value The value being parsed
* @param bool $allowMultiple Can $value contain more than one value
* separated by '|'?
- * @param mixed $allowedValues An array of values to check against. If
+ * @param array|null $allowedValues An array of values to check
against. If
* null, all values are accepted.
- * @return mixed (allowMultiple ? an_array_of_values : a_single_value)
+ * @return string|array (allowMultiple ? an_array_of_values :
a_single_value)
*/
protected function parseMultiValue( $valueName, $value, $allowMultiple,
$allowedValues ) {
if ( trim( $value ) === '' && $allowMultiple ) {
diff --git a/includes/api/ApiQueryBase.php b/includes/api/ApiQueryBase.php
index 8e014df..067a076 100644
--- a/includes/api/ApiQueryBase.php
+++ b/includes/api/ApiQueryBase.php
@@ -75,8 +75,8 @@
/**
* Add a set of tables to the internal array
- * @param mixed $tables Table name or array of table names
- * @param mixed $alias Table alias, or null for no alias. Cannot be
+ * @param string|array $tables Table name or array of table names
+ * @param string|null $alias Table alias, or null for no alias. Cannot
be
* used with multiple tables
*/
protected function addTables( $tables, $alias = null ) {
diff --git a/includes/api/ApiQueryRecentChanges.php
b/includes/api/ApiQueryRecentChanges.php
index e4078d5..c35d39b 100644
--- a/includes/api/ApiQueryRecentChanges.php
+++ b/includes/api/ApiQueryRecentChanges.php
@@ -405,7 +405,7 @@
/**
* Extracts from a single sql row the data needed to describe one
recent change.
*
- * @param mixed $row The row from which to extract the data.
+ * @param stdClass $row The row from which to extract the data.
* @return array An array mapping strings (descriptors) to their
respective string values.
* @access public
*/
diff --git a/includes/api/ApiQueryUserContributions.php
b/includes/api/ApiQueryUserContributions.php
index 24c4c20..5f93071 100644
--- a/includes/api/ApiQueryUserContributions.php
+++ b/includes/api/ApiQueryUserContributions.php
@@ -326,7 +326,7 @@
/**
* Extract fields from the database row and append them to a result
array
*
- * @param mixed $row
+ * @param stdClass $row
* @return array
*/
private function extractRowInfo( $row ) {
--
To view, visit https://gerrit.wikimedia.org/r/144032
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2ab4b0ae452325392c4ea72ab3d985107d429ac2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <umherirrender_de...@web.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
