jenkins-bot has submitted this change and it was merged.
Change subject: Allow "size" attribute to HTMLSelectField
......................................................................
Allow "size" attribute to HTMLSelectField
Pass this one to XmlSelect is provided.
Change-Id: I7ac345e1c219c8607895f9fc0fc2cef68c900ff8
---
M includes/htmlform/HTMLSelectField.php
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Hoo man: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/htmlform/HTMLSelectField.php
b/includes/htmlform/HTMLSelectField.php
index c32b445..2bf9f8b 100644
--- a/includes/htmlform/HTMLSelectField.php
+++ b/includes/htmlform/HTMLSelectField.php
@@ -27,8 +27,10 @@
$select->setAttribute( 'disabled', 'disabled' );
}
- if ( isset( $this->mParams['tabindex'] ) ) {
- $select->setAttribute( 'tabindex',
$this->mParams['tabindex'] );
+ $allowedParams = array( 'tabindex', 'size' );
+ $customParams = $this->getAttributes( $allowedParams );
+ foreach( $customParams as $name => $value ) {
+ $select->setAttribute( $name, $value );
}
if ( $this->mClass !== '' ) {
--
To view, visit https://gerrit.wikimedia.org/r/144371
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7ac345e1c219c8607895f9fc0fc2cef68c900ff8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: IAlex <coderev...@emsenhuber.ch>
Gerrit-Reviewer: Aaron Schulz <asch...@wikimedia.org>
Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: Daniel Friesen <dan...@nadir-seen-fire.com>
Gerrit-Reviewer: Hoo man <h...@online.de>
Gerrit-Reviewer: Reedy <re...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
