Mwalker has submitted this change and it was merged.
Change subject: Pass jshint on modules/ext.fundraisingChart.datamaps
......................................................................
Pass jshint on modules/ext.fundraisingChart.datamaps
Straightforward missing semicolons and a few comparaison with null.
Bug: 66192
Change-Id: Ib5c04f7247ca9045e7c28f5ed44e211935dbe579
---
M modules/ext.fundraisingChart.datamaps/datamaps.world.js
1 file changed, 5 insertions(+), 5 deletions(-)
Approvals:
Ssmith: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ext.fundraisingChart.datamaps/datamaps.world.js
b/modules/ext.fundraisingChart.datamaps/datamaps.world.js
index 64c7da3..cd21c68 100644
--- a/modules/ext.fundraisingChart.datamaps/datamaps.world.js
+++ b/modules/ext.fundraisingChart.datamaps/datamaps.world.js
@@ -240,7 +240,7 @@
if ( datum.options && datum.options.strokeColor) {
return datum.options.strokeColor;
}
- return options.strokeColor
+ return options.strokeColor;
})
.style('fill', 'none')
.style('stroke-width', function(datum) {
@@ -270,7 +270,7 @@
this.style.transition = this.style.WebkitTransition =
'stroke-dashoffset ' + options.animationSpeed + 'ms ease-out';
this.style.strokeDashoffset = '0';
return 'none';
- })
+ });
arcs.exit()
.transition()
@@ -308,7 +308,7 @@
.attr("x2", center[0])
.attr("y2", center[1])
.style("stroke", options.labelColor || "#000")
- .style("stroke-width", options.lineWidth || 1)
+ .style("stroke-width", options.lineWidth || 1);
}
layer.append("text")
@@ -409,7 +409,7 @@
Array.prototype.slice.call(arguments, 1).forEach(function(source) {
if (source) {
for (var prop in source) {
- if (obj[prop] == null) obj[prop] = source[prop];
+ if (obj[prop] === null) obj[prop] = source[prop];
}
}
});
@@ -507,7 +507,7 @@
//add <g> layer to root SVG
Datamap.prototype.addLayer = function( className, id ) {
- d3.select()
+ d3.select();
return this.svg.append('g')
.attr('id', id || '')
.attr('class', className || '');
--
To view, visit https://gerrit.wikimedia.org/r/144432
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib5c04f7247ca9045e7c28f5ed44e211935dbe579
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/FundraisingChart
Gerrit-Branch: master
Gerrit-Owner: Hashar <[email protected]>
Gerrit-Reviewer: Awight <[email protected]>
Gerrit-Reviewer: Ejegg <[email protected]>
Gerrit-Reviewer: Mwalker <[email protected]>
Gerrit-Reviewer: Ssmith <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
