TheDJ has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/145327

Change subject: Allow on the fly loading of language modes
......................................................................

Allow on the fly loading of language modes

Change-Id: Ie04138677dead4c23b1bcfef4e1f7a2cd6e8826e
---
M modules/jquery.codeEditor.js
1 file changed, 4 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CodeEditor 
refs/changes/27/145327/1

diff --git a/modules/jquery.codeEditor.js b/modules/jquery.codeEditor.js
index 42a7979..c7f46df 100644
--- a/modules/jquery.codeEditor.js
+++ b/modules/jquery.codeEditor.js
@@ -228,8 +228,10 @@
                                        // updated right away to actually use 
the new style.
                                        $( mw ).bind( 'LivePreviewPrepare', 
context.evt.codeEditorSubmit );
 
-                                       AceLangMode = require( 'ace/mode/' + 
lang ).Mode;
-                                       session.setMode( new AceLangMode() );
+                                       ace.config.loadModule( 'ace/mode/' + 
lang, function() {
+                                               AceLangMode = require( 
'ace/mode/' + lang ).Mode;
+                                               session.setMode( new 
AceLangMode() );
+                                       });
 
                                        // Force the box to resize horizontally 
to match in future :D
                                        resize = function () {

-- 
To view, visit https://gerrit.wikimedia.org/r/145327
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie04138677dead4c23b1bcfef4e1f7a2cd6e8826e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CodeEditor
Gerrit-Branch: master
Gerrit-Owner: TheDJ <hartman.w...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to