jenkins-bot has submitted this change and it was merged. Change subject: Upgrade e5-shim to v4.0.0 ......................................................................
Upgrade e5-shim to v4.0.0 Source code: https://github.com/es-shims/es5-shim/blob/v4.0.0/es5-shim.js Follows-up 61c81de, dcdca49, and ea307ea. Notable changes; * Removes breaking polyfill for Array#splice https://github.com/es-shims/es5-shim/issues/255 Change-Id: Id1bf4b5f35fed05817f77e087cd489aed719ecd5 --- M RELEASE-NOTES-1.24 M resources/lib/es5-shim/es5-shim.js 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Jforrester: Looks good to me, approved jenkins-bot: Verified diff --git a/RELEASE-NOTES-1.24 b/RELEASE-NOTES-1.24 index ec31355..f4acc37 100644 --- a/RELEASE-NOTES-1.24 +++ b/RELEASE-NOTES-1.24 @@ -110,6 +110,7 @@ * Upgrade Moment.js to v2.7.0. * (bug 67042) Added support for the HTML5 <rtc> tag for East Asian typography. * Upgrade Sinon.JS to 1.10.3. +* Added the es5-shim polyfill for older or non-compliant javascript engines. === Bug fixes in 1.24 === * (bug 49116) Footer copyright notice is now always displayed in user language diff --git a/resources/lib/es5-shim/es5-shim.js b/resources/lib/es5-shim/es5-shim.js index d20aa1b..4595994 100644 --- a/resources/lib/es5-shim/es5-shim.js +++ b/resources/lib/es5-shim/es5-shim.js @@ -366,7 +366,6 @@ ArrayPrototype.splice.call(obj, 0, 0, 1); return obj.length === 1; }()); -var omittingSecondSpliceArgIsNoop = [1].splice(0).length === 0; defineProperties(ArrayPrototype, { splice: function splice(start, deleteCount) { if (arguments.length === 0) { return []; } @@ -375,14 +374,14 @@ if (arguments.length > 0 && typeof deleteCount !== 'number') { args = _Array_slice_.call(arguments); if (args.length < 2) { - args.push(toInteger(deleteCount)); + args.push(this.length - start); } else { args[1] = toInteger(deleteCount); } } return array_splice.apply(this, args); } -}, !omittingSecondSpliceArgIsNoop || !spliceWorksWithEmptyObject); +}, !spliceWorksWithEmptyObject); // ES5 15.4.4.12 // http://es5.github.com/#x15.4.4.13 -- To view, visit https://gerrit.wikimedia.org/r/145429 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1bf4b5f35fed05817f77e087cd489aed719ecd5 Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Krinkle <krinklem...@gmail.com> Gerrit-Reviewer: Alex Monk <kren...@wikimedia.org> Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com> Gerrit-Reviewer: Jack Phoenix <j...@countervandalism.net> Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org> Gerrit-Reviewer: Krinkle <krinklem...@gmail.com> Gerrit-Reviewer: Ori.livneh <o...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
