Hoo man has uploaded a new change for review.
https://gerrit.wikimedia.org/r/145553
Change subject: Fix SectionEditLinkGeneratorTest for non-English wikis
......................................................................
Fix SectionEditLinkGeneratorTest for non-English wikis
This can eg. be seen on Spanish or Russian wikis where
the localized version of Special:Version contains non-ASCII
characters.
Change-Id: Ic2295e0319b1580eda1e602174cadee0325d44ae
---
M repo/tests/phpunit/includes/View/SectionEditLinkGeneratorTest.php
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/53/145553/1
diff --git a/repo/tests/phpunit/includes/View/SectionEditLinkGeneratorTest.php
b/repo/tests/phpunit/includes/View/SectionEditLinkGeneratorTest.php
index b692c8f..4d046e7 100644
--- a/repo/tests/phpunit/includes/View/SectionEditLinkGeneratorTest.php
+++ b/repo/tests/phpunit/includes/View/SectionEditLinkGeneratorTest.php
@@ -42,14 +42,14 @@
return array(
array(
'/' . wfMessage( 'wikibase-edit' )->inLanguage(
'es' )->text() . '/',
- 'Version',
+ \SpecialPage::getTitleFor( 'Version'
)->getText(),
'edit',
true,
'es'
),
array(
'/' . wfMessage( 'wikibase-add' )->inLanguage(
'de' )->text() . '/',
- 'Version',
+ \SpecialPage::getTitleFor( 'Version'
)->getText(),
'add',
true,
'de'
@@ -75,7 +75,7 @@
array(
'tag' => 'a',
'attributes' => array(
- 'href' => 'regexp:+' .
preg_quote( SpecialPageFactory::getLocalNameFor( 'Version' ), '+' ) . '/Q1$+',
+ 'href' => 'regexp:+' .
preg_quote( urlencode( SpecialPageFactory::getLocalNameFor( 'Version' ) ), '+'
) . '/Q1$+',
)
),
'Version',
@@ -85,7 +85,7 @@
array(
'tag' => 'a',
'attributes' => array(
- 'href' => 'regexp:+' .
preg_quote( SpecialPageFactory::getLocalNameFor( 'Version' ), '+' ) .
'/Q1/de$+',
+ 'href' => 'regexp:+' .
preg_quote( urlencode( SpecialPageFactory::getLocalNameFor( 'Version' ) ), '+'
) . '/Q1/de$+',
)
),
'Version',
--
To view, visit https://gerrit.wikimedia.org/r/145553
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic2295e0319b1580eda1e602174cadee0325d44ae
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Hoo man <h...@online.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
