[MediaWiki-commits] [Gerrit] Make ChangeLineFormatterTest completely independent of lang ... - change (mediawiki...Wikibase)

[Aude (Code Review)]

Aude has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/145564

Change subject: Make ChangeLineFormatterTest completely independent of lang 
setting
......................................................................

Make ChangeLineFormatterTest completely independent of lang setting

The number formatting otherwise fails if the wiki is set
to Arabic or such language.

Change-Id: Ib965db08b07ecfb8966372523502dc306029b1b6
---
M client/tests/phpunit/includes/recentchanges/ChangeLineFormatterTest.php
1 file changed, 17 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/64/145564/1

diff --git 
a/client/tests/phpunit/includes/recentchanges/ChangeLineFormatterTest.php 
b/client/tests/phpunit/includes/recentchanges/ChangeLineFormatterTest.php
index c8973a6..93bde72 100644
--- a/client/tests/phpunit/includes/recentchanges/ChangeLineFormatterTest.php
+++ b/client/tests/phpunit/includes/recentchanges/ChangeLineFormatterTest.php
@@ -3,9 +3,11 @@
 namespace Wikibase\Test;
 
 use ChangesList;
+use DerivativeContext;
 use Language;
 use RecentChange;
 use RequestContext;
+use User;
 use Wikibase\ChangeLineFormatter;
 use Wikibase\ExternalChangeFactory;
 use Wikibase\RepoLinker;
@@ -52,16 +54,15 @@
         * @dataProvider formatProvider
         */
        public function testFormat( array $expectedTags, array $patterns, 
RecentChange $recentChange ) {
-               $context = new RequestContext();
+               $context = $this->getTestContext();
+
                $changesList = ChangesList::newFromContext( $context );
-
                $changeFactory = new ExternalChangeFactory( 'testrepo' );
-
                $externalChange = $changeFactory->newFromRecentChange( 
$recentChange );
 
                $formatter = new ChangeLineFormatter(
                        $changesList->getUser(),
-                       $changesList->getLanguage(),
+                       Language::factory( 'en' ),
                        $this->repoLinker
                );
 
@@ -72,6 +73,10 @@
                        $changesList->recentChangesFlags( array( 
'wikibase-edit' => true ), '' )
                );
 
+               if( preg_match( '/mw-changeslist-date/', $formattedLine ) ) {
+               //      echo "$formattedLine\n";
+               }
+
                foreach( $expectedTags as $key => $tag ) {
                        $this->assertTag( $tag, $formattedLine, $key );
                }
@@ -81,6 +86,14 @@
                }
        }
 
+       private function getTestContext() {
+               $context = new DerivativeContext( RequestContext::getMain() );
+               $context->setLanguage( Language::factory( 'en' ) );
+               $context->setUser( User::newFromId( 0 ) );
+
+               return $context;
+       }
+
        public function formatProvider() {
                return array(
                        array(

-- 
To view, visit https://gerrit.wikimedia.org/r/145564
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib965db08b07ecfb8966372523502dc306029b1b6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Aude <aude.w...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits