Dr0ptp4kt has uploaded a new change for review.
https://gerrit.wikimedia.org/r/145707
Change subject: Log when OM slot missing or has unexpected value.
......................................................................
Log when OM slot missing or has unexpected value.
Change-Id: Ia9abf43b9494c0000a28fe567d65e30824fb3bf9
---
M includes/PageRendering.php
1 file changed, 7 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ZeroBanner
refs/changes/07/145707/1
diff --git a/includes/PageRendering.php b/includes/PageRendering.php
index a0f447f..a1eef1e 100644
--- a/includes/PageRendering.php
+++ b/includes/PageRendering.php
@@ -273,6 +273,13 @@
if ( $this->isUnifiedZero() || $this->getZeroConfig() ||
$this->isZeroSubdomain ) {
$out->addModuleStyles( 'zerobanner.styles' );
$out->addModules( 'zerobanner' );
+
+ // @TODO: remove slot check logging after a while
+ $xfb = $request->getHeader( 'X-Forwarded-By' );
+ // Noteworthy cases to log: missing header, empty
string, or string literal '0'
+ if ( $xfb === 'Opera' && !$request->getHeader(
'X-OPERAMINI-ROUTE' ) ) {
+ self::logDebug( '!slot' );
+ }
}
$out->addVaryHeader( 'X-CS' );
--
To view, visit https://gerrit.wikimedia.org/r/145707
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia9abf43b9494c0000a28fe567d65e30824fb3bf9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ZeroBanner
Gerrit-Branch: master
Gerrit-Owner: Dr0ptp4kt <ab...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
