Taueres has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/145859

Change subject: WebInstaller::setVarsFromRequest() do not trim passwords
......................................................................

WebInstaller::setVarsFromRequest() do not trim passwords

Bug: 30524
Change-Id: Ide30c9078ae8cbf97a6f86c4e230f44ce8382a1f
---
M includes/installer/WebInstaller.php
1 file changed, 5 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/59/145859/1

diff --git a/includes/installer/WebInstaller.php 
b/includes/installer/WebInstaller.php
index 46348f9..c4e35e9a 100644
--- a/includes/installer/WebInstaller.php
+++ b/includes/installer/WebInstaller.php
@@ -1051,7 +1051,11 @@
                $newValues = array();
 
                foreach ( $varNames as $name ) {
-                       $value = trim( $this->request->getVal( $prefix . $name 
) );
+                       $value = $this->request->getVal( $prefix . $name );
+                       // bug 30524, do not trim passwords
+                       if ( stripos( $name, 'password' ) === false ) {
+                               $value = trim( $value );
+                       }
                        $newValues[$name] = $value;
 
                        if ( $value === null ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/145859
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ide30c9078ae8cbf97a6f86c4e230f44ce8382a1f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Taueres <santoro....@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to