Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/145906
Change subject: Remove misplaced knowledge from comments
......................................................................
Remove misplaced knowledge from comments
Change-Id: Ia734ae7165b637dd3ffa2701baababcf10cf078f
---
M repo/includes/store/IdGenerator.php
M repo/includes/store/sql/SqlIdGenerator.php
2 files changed, 6 insertions(+), 7 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/06/145906/1
diff --git a/repo/includes/store/IdGenerator.php
b/repo/includes/store/IdGenerator.php
index 6d642b5..ca61391 100644
--- a/repo/includes/store/IdGenerator.php
+++ b/repo/includes/store/IdGenerator.php
@@ -3,7 +3,8 @@
namespace Wikibase;
/**
- * Contains methods to generate and obtain an unique id.
+ * Generates a new unique numeric id for the provided type.
+ * Ids are only unique per type.
*
* @since 0.1
*
@@ -15,9 +16,7 @@
/**
* @since 0.1
*
- * @todo: Change this to return an EntityId
- *
- * @param string $type Usually the content model identifier, e.g.
'wikibase-item'.
+ * @param string $type
*
* @return int
*/
diff --git a/repo/includes/store/sql/SqlIdGenerator.php
b/repo/includes/store/sql/SqlIdGenerator.php
index db5f8ee..08fa976 100644
--- a/repo/includes/store/sql/SqlIdGenerator.php
+++ b/repo/includes/store/sql/SqlIdGenerator.php
@@ -45,9 +45,9 @@
}
/**
- * @see IdIncrementer::getNewId
+ * @see IdGenerator::getNewId
*
- * @param string $type Usually the content model identifier, e.g.
'wikibase-item'.
+ * @param string $type
*
* @return int
*/
@@ -60,7 +60,7 @@
*
* @since 0,1
*
- * @param string $type Usually the content model identifier, e.g.
'wikibase-item'.
+ * @param string $type
* @param bool $retry Retry once in case of e.g. race conditions.
Defaults to true.
*
* @throws MWException
--
To view, visit https://gerrit.wikimedia.org/r/145906
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia734ae7165b637dd3ffa2701baababcf10cf078f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <jeroended...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
