Jeroen De Dauw has submitted this change and it was merged.
Change subject: Remove dead code path
......................................................................
Remove dead code path
Change-Id: Ic92fdf32e1b74caedefebcc087ced6b89e40bfc1
---
M repo/resources/wikibase.ui.entityViewInit.js
1 file changed, 2 insertions(+), 6 deletions(-)
Approvals:
WikidataJenkins: Verified
Thiemo Mättig (WMDE): Looks good to me, but someone else must approve
Jeroen De Dauw: Looks good to me, approved
diff --git a/repo/resources/wikibase.ui.entityViewInit.js
b/repo/resources/wikibase.ui.entityViewInit.js
index b236b19..2d712f2 100644
--- a/repo/resources/wikibase.ui.entityViewInit.js
+++ b/repo/resources/wikibase.ui.entityViewInit.js
@@ -56,13 +56,9 @@
}
// add an edit tool for all properties in the data view:
- $( '.wb-property-container' ).each( function() {
+ $( '.wb-property-container:has( >
.wb-property-container-key[title=description] )' ).each( function() {
// TODO: Make this nicer when we have implemented the
data model
- if( $( this ).children( '.wb-property-container-key'
).attr( 'title' ) === 'description' ) {
- new wb.ui.DescriptionEditTool( this );
- } else {
- new wb.ui.PropertyEditTool( this );
- }
+ new wb.ui.DescriptionEditTool( this );
} );
if( mw.config.get( 'wbEntity' ) !== null ) {
--
To view, visit https://gerrit.wikimedia.org/r/145236
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic92fdf32e1b74caedefebcc087ced6b89e40bfc1
Gerrit-PatchSet: 6
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Adrian Lang <adrian.l...@wikimedia.de>
Gerrit-Reviewer: Jeroen De Dauw <jeroended...@gmail.com>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
Gerrit-Reviewer: WikidataJenkins <wikidata-servi...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
