Brion VIBBER has submitted this change and it was merged.
Change subject: Slight adjustment to alert hiding to ensure fade interrupted.
......................................................................
Slight adjustment to alert hiding to ensure fade interrupted.
Change-Id: If78247cd2d65fdb8d4ac8e508528d50bf751e3c2
---
M wikipedia/Categories/Alerts/UIViewController+Alert.m
1 file changed, 5 insertions(+), 2 deletions(-)
Approvals:
Brion VIBBER: Verified; Looks good to me, approved
diff --git a/wikipedia/Categories/Alerts/UIViewController+Alert.m
b/wikipedia/Categories/Alerts/UIViewController+Alert.m
index 6066a30..1f1fa59 100644
--- a/wikipedia/Categories/Alerts/UIViewController+Alert.m
+++ b/wikipedia/Categories/Alerts/UIViewController+Alert.m
@@ -4,6 +4,7 @@
#import "UIViewController+Alert.h"
#import "AlertLabel.h"
#import "AlertWebView.h"
+#import "UIView+RemoveConstraints.h"
@implementation UIViewController (Alert)
@@ -44,10 +45,12 @@
-(void)hideAlert
{
- // Hide alert immediately.
+ // Hide alert immediately. Removes it so any running fade animations don't
prevent immediate hide.
AlertLabel *alertLabel = [self getExistingViewOfClass:[AlertLabel class]
inContainer:self.view];
if (alertLabel) {
- alertLabel.alpha = 0.0;
+ [alertLabel removeConstraintsOfViewFromView:self.view];
+ [alertLabel removeFromSuperview];
+ alertLabel = nil;
}
}
--
To view, visit https://gerrit.wikimedia.org/r/146900
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If78247cd2d65fdb8d4ac8e508528d50bf751e3c2
Gerrit-PatchSet: 1
Gerrit-Project: apps/ios/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Mhurd <mh...@wikimedia.org>
Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
