jenkins-bot has submitted this change and it was merged.
Change subject: Adding css styling option for help option in HTMLForm
......................................................................
Adding css styling option for help option in HTMLForm
There is now a new option named csshelpclass that can be passed in form
descriptors for HTMLForm objects. This option accepts a css class and
applies it to the help text that is provided with the help option in the
form descriptor.
Bug: 65087
Change-Id: If1bd1d12a9159895f45c9cf0fbb7992e4c7e3526
---
M includes/htmlform/HTMLForm.php
M includes/htmlform/HTMLFormField.php
2 files changed, 11 insertions(+), 1 deletion(-)
Approvals:
Brian Wolff: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/htmlform/HTMLForm.php b/includes/htmlform/HTMLForm.php
index 3334694..df6582c 100644
--- a/includes/htmlform/HTMLForm.php
+++ b/includes/htmlform/HTMLForm.php
@@ -50,6 +50,7 @@
* 'default' -- default value when the form is displayed
* 'id' -- HTML id attribute
* 'cssclass' -- CSS class
+ * 'csshelpclass' -- CSS class used to style help text
* 'options' -- associative array mapping labels to values.
* Some field types support multi-level arrays.
* 'options-messages' -- associative array mapping message keys to
values.
diff --git a/includes/htmlform/HTMLFormField.php
b/includes/htmlform/HTMLFormField.php
index 8076e8a..1fcc866 100644
--- a/includes/htmlform/HTMLFormField.php
+++ b/includes/htmlform/HTMLFormField.php
@@ -13,6 +13,7 @@
protected $mLabel; # String label. Set on construction
protected $mID;
protected $mClass = '';
+ protected $mHelpClass = false;
protected $mDefault;
protected $mOptions = false;
protected $mOptionsLabelsNotFromMessage = false;
@@ -397,6 +398,10 @@
$this->mClass = $params['cssclass'];
}
+ if ( isset( $params['csshelpclass'] ) ) {
+ $this->mHelpClass = $params['csshelpclass'];
+ }
+
if ( isset( $params['validation-callback'] ) ) {
$this->mValidationCallback =
$params['validation-callback'];
}
@@ -562,7 +567,11 @@
$rowAttributes['class'] = 'mw-htmlform-hide-if';
}
- $row = Html::rawElement( 'td', array( 'colspan' => 2, 'class'
=> 'htmlform-tip' ), $helptext );
+ $tdClasses = array( 'htmlform-tip' );
+ if ( $this->mHelpClass !== false ) {
+ $tdClasses[] = $this->mHelpClass;
+ }
+ $row = Html::rawElement( 'td', array( 'colspan' => 2, 'class'
=> $tdClasses ), $helptext );
$row = Html::rawElement( 'tr', $rowAttributes, $row );
return $row;
--
To view, visit https://gerrit.wikimedia.org/r/132946
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If1bd1d12a9159895f45c9cf0fbb7992e4c7e3526
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader <[email protected]>
Gerrit-Reviewer: Brian Wolff <[email protected]>
Gerrit-Reviewer: Daniel Friesen <[email protected]>
Gerrit-Reviewer: Gerrit Patch Uploader <[email protected]>
Gerrit-Reviewer: Isarra <[email protected]>
Gerrit-Reviewer: Jack Phoenix <[email protected]>
Gerrit-Reviewer: Zellfaze <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
