jenkins-bot has submitted this change and it was merged.
Change subject: Fix navigation buttons on Special:Listfiles for first and last
page
......................................................................
Fix navigation buttons on Special:Listfiles for first and last page
The listfiles pager was appending the username to the paging queries
for all paging queries. On the first/last page, this was appending
the username to false, thus marking the first/last page as still having
further results despite that not being the case.
Bug: 67627
Change-Id: Ib302a826fa638d7ae25c6d37951277fa8701ab69
---
M includes/specials/SpecialListfiles.php
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Brian Wolff: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/specials/SpecialListfiles.php
b/includes/specials/SpecialListfiles.php
index 3715b8b..8e17015 100644
--- a/includes/specials/SpecialListfiles.php
+++ b/includes/specials/SpecialListfiles.php
@@ -547,7 +547,9 @@
if ( !is_null( $this->mUserName ) ) {
# Append the username to the query string
foreach ( $queries as &$query ) {
- $query['user'] = $this->mUserName;
+ if ( $query !== false ) {
+ $query['user'] = $this->mUserName;
+ }
}
}
--
To view, visit https://gerrit.wikimedia.org/r/144941
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib302a826fa638d7ae25c6d37951277fa8701ab69
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Rohan013 <[email protected]>
Gerrit-Reviewer: Brian Wolff <[email protected]>
Gerrit-Reviewer: Gergő Tisza <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: btongminh <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
