Brion VIBBER has uploaded a new change for review.
https://gerrit.wikimedia.org/r/147134
Change subject: Put 'action' before 'format' on API parameters to fix app
indexing
......................................................................
Put 'action' before 'format' on API parameters to fix app indexing
Our robots.txt whitelists API requests for action=mobileview...
but only if action=mobileview appears as the first parameter.
This is required for Google's app search indexing, which otherwise
detects we've fetched something outside robots.txt and gets confused.
Change-Id: I991bd40574e5311c6e3cd8fa646f31ccb6e420ac
---
M src/main/java/org/mediawiki/api/json/RequestBuilder.java
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/java-mwapi
refs/changes/34/147134/1
diff --git a/src/main/java/org/mediawiki/api/json/RequestBuilder.java
b/src/main/java/org/mediawiki/api/json/RequestBuilder.java
index 7a0fd17..11bb6f3 100644
--- a/src/main/java/org/mediawiki/api/json/RequestBuilder.java
+++ b/src/main/java/org/mediawiki/api/json/RequestBuilder.java
@@ -25,8 +25,8 @@
RequestBuilder(final Api apiToUse, final String action) {
this.api = apiToUse;
params = new HashMap<String, String>();
+ params.put("action", action); // put action first to match robots.txt
whitelist of action=mobileview for app search indexing
params.put("format", "json"); // Force everything to be JSON
- params.put("action", action);
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/147134
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I991bd40574e5311c6e3cd8fa646f31ccb6e420ac
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/java-mwapi
Gerrit-Branch: master
Gerrit-Owner: Brion VIBBER <br...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
