Awight has uploaded a new change for review. https://gerrit.wikimedia.org/r/147406
Change subject: Workaround strict class inheritance check ...................................................................... Workaround strict class inheritance check Extension:Translate explicitly checks that this is a Page Translation message group. Dive into the "Uncanny valley" and make this repugnant class look even more convincingly fake :( TODO: use duck-typing or interfaces in Extension:Translate. Stop dealing with message groups as class objects, use hooks instead. and Aargh. Change-Id: I28faf8cf7e9613bb1b14bd42e550ff1abb1ebdf5 --- M FundraisingMessageGroup.php 1 file changed, 5 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/FundraisingTranslateWorkflow refs/changes/06/147406/1 diff --git a/FundraisingMessageGroup.php b/FundraisingMessageGroup.php index ddc22cf..00cecbc 100644 --- a/FundraisingMessageGroup.php +++ b/FundraisingMessageGroup.php @@ -4,11 +4,15 @@ use \IContextSource; use \MessageGroup; use \MessageGroupStates; +use \WikiPageMessageGroup; /** * Wrapper to modify message group behavior */ -class FundraisingMessageGroup implements MessageGroup { +class FundraisingMessageGroup + extends WikiPageMessageGroup + // TODO: ideally would be "implements MessageGroup" +{ /** * TranslatePostInitGroups hook handler * -- To view, visit https://gerrit.wikimedia.org/r/147406 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I28faf8cf7e9613bb1b14bd42e550ff1abb1ebdf5 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/FundraisingTranslateWorkflow Gerrit-Branch: master Gerrit-Owner: Awight <awi...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits