Vikassy has uploaded a new change for review. https://gerrit.wikimedia.org/r/147413
Change subject: [BrowserTest] Fixed failing Media Icon tests ...................................................................... [BrowserTest] Fixed failing Media Icon tests Change-Id: I1d07398f1b8f999c76dc278ed8950778ba1e8fd9 --- M modules/ve-mw/tests/browser/features/step_definitions/language_screenshot_steps.rb M modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor refs/changes/13/147413/1 diff --git a/modules/ve-mw/tests/browser/features/step_definitions/language_screenshot_steps.rb b/modules/ve-mw/tests/browser/features/step_definitions/language_screenshot_steps.rb index 5390290..19c29f1 100644 --- a/modules/ve-mw/tests/browser/features/step_definitions/language_screenshot_steps.rb +++ b/modules/ve-mw/tests/browser/features/step_definitions/language_screenshot_steps.rb @@ -5,7 +5,7 @@ Given(/^I select the image in VisualEditor$/) do step "I click in the editable part" - on(VisualEditorPage).content_element.send_keys :arrow_left + on(VisualEditorPage).media_image_element.when_present.click end Given (/^I go to "(.+)" page which has references$/) do |page_title| diff --git a/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb b/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb index 7b5df5a..3131d4b 100644 --- a/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb +++ b/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb @@ -39,7 +39,7 @@ div(:page_option_menu, class: "oo-ui-toolGroup-tools oo-ui-clippableElement-clippable", index: 5) span(:special_character, class: "oo-ui-iconedElement-icon oo-ui-icon-special-character") div(:iframe, class: "oo-ui-window-frame") - image(:media_image, class: "ve-ce-focusableNode-highlight-relocatable-marker") + figure(:media_image, index: 0) unordered_list(:media_caption, class: "ve-ui-contextMenuWidget") span(:cite_menu, class: "oo-ui-popupToolGroup-handle", index: 2) div(:cite_pull_down, class: "oo-ui-toolGroup-tools oo-ui-clippableElement-clippable", index: 2) -- To view, visit https://gerrit.wikimedia.org/r/147413 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1d07398f1b8f999c76dc278ed8950778ba1e8fd9 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Vikassy <vikasyaligar...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
