Robert Vogel has submitted this change and it was merged. Change subject: Don't query discussion amount on non existing pages ......................................................................
Don't query discussion amount on non existing pages This ended in a fatal error because no Title object could be created for given id 0 Change-Id: Ibfa83ae369ac77dbd13a04dba5413f21bf9ec2c9 --- M resources/components/skin.contentActions.js 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Robert Vogel: Verified; Looks good to me, approved diff --git a/resources/components/skin.contentActions.js b/resources/components/skin.contentActions.js index cec708e..b57412e 100644 --- a/resources/components/skin.contentActions.js +++ b/resources/components/skin.contentActions.js @@ -8,7 +8,7 @@ (function(mw, $){ $(function(){ - if ( wgIsArticle === true ) { + if ( wgIsArticle === true && wgArticleId !== 0 ) { $.getJSON( bs.util.getAjaxDispatcherUrl('BlueSpiceSkinHooks::ajaxGetDiscussionCount', [], true), function( data ) { -- To view, visit https://gerrit.wikimedia.org/r/147426 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibfa83ae369ac77dbd13a04dba5413f21bf9ec2c9 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/skins/BlueSpiceSkin Gerrit-Branch: master Gerrit-Owner: Smuggli <mug...@hallowelt.biz> Gerrit-Reviewer: Mglaser <gla...@hallowelt.biz> Gerrit-Reviewer: Pigpen <reym...@hallowelt.biz> Gerrit-Reviewer: Robert Vogel <vo...@hallowelt.biz> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits