jenkins-bot has submitted this change and it was merged.
Change subject: fixed a bug in dom.linter and added a new linter test for it
......................................................................
fixed a bug in dom.linter and added a new linter test for it
Change-Id: I397bf45059b64201ddf34209db8e32298c830aa3
---
M lib/dom.linter.js
M tests/mocha/lintertest.js
2 files changed, 10 insertions(+), 1 deletion(-)
Approvals:
Subramanya Sastry: Looks good to me, approved
jenkins-bot: Verified
diff --git a/lib/dom.linter.js b/lib/dom.linter.js
index e59a87d..d23670b 100644
--- a/lib/dom.linter.js
+++ b/lib/dom.linter.js
@@ -119,7 +119,7 @@
// Discard attributes that are only whitespace and
comments
for (var a in dp.sa) {
var re = /^\s*$|\n[
\t]*<!--([^-]|-(?!->))*-->([ \t]|<!--([^-]|-(?!->))*-->)*\n/g;
- if (a && dp.sa.a && (!re.test(a) ||
!re.test(dp.sa.a))) {
+ if ( (a || dp.sa.a) && (!re.test(a) ||
!re.test(dp.sa.a))) {
wc = true;
}
}
diff --git a/tests/mocha/lintertest.js b/tests/mocha/lintertest.js
index f880251..91f00b6 100644
--- a/tests/mocha/lintertest.js
+++ b/tests/mocha/lintertest.js
@@ -88,5 +88,14 @@
result[0].should.have.a.property( "src", "foo"
);
});
});
+ it('should lint ignored table attributes Correctly',
function(done){
+ return parseWT( '{|\n|- foo\n|bar\n|}' ).done( function
( result ) {
+ result.should.have.length( 1 );
+ result[0].should.have.a.property("type",
"ignored-table-attr");
+ result[0].should.have.a.property("wiki",
"enwiki");
+ result[0].dsr.should.include.members([ 3, 14,
6, 0 ]);
+ result[0].should.have.a.property("src", "|-
foo\n|bar");
+ });
+ });
});
});
--
To view, visit https://gerrit.wikimedia.org/r/147634
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I397bf45059b64201ddf34209db8e32298c830aa3
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: Hardikj <hardikjuneja...@gmail.com>
Gerrit-Reviewer: Subramanya Sastry <ssas...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
