jenkins-bot has submitted this change and it was merged.
Change subject: Hygiene: Some clean-up of mobile Resources.php
......................................................................
Hygiene: Some clean-up of mobile Resources.php
Getting rid of boilerplate variable that is only used once and serves
no purpose other than to add one dependency.
Replacing list of dependencies for mobile.special.uploads.scripts
with single mobile.stable dependency (which includes all the rest).
Change-Id: Ib9054ac6842de4e73f3f8c34d1a5546bfe0dcef4
---
M includes/Resources.php
1 file changed, 5 insertions(+), 12 deletions(-)
Approvals:
JGonera: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/Resources.php b/includes/Resources.php
index 5a0bc93..60af0da 100644
--- a/includes/Resources.php
+++ b/includes/Resources.php
@@ -24,13 +24,6 @@
die( 'Not an entry point.' );
}
-/**
- * A boilerplate for RL script modules
-*/
-$wgMFMobileSpecialPageResourceScriptBoilerplate =
$wgMFMobileSpecialPageResourceBoilerplate + array(
- 'dependencies' => array( 'mobile.stable' ),
-);
-
$wgResourceModules = array_merge( $wgResourceModules, array(
// @todo FIXME: Upstream to core
'mobile.templates' => $wgMFMobileResourceBoilerplate + array(
@@ -1101,7 +1094,10 @@
'position' => 'top',
),
- 'mobile.special.notifications.scripts' =>
$wgMFMobileSpecialPageResourceScriptBoilerplate + array(
+ 'mobile.special.notifications.scripts' =>
$wgMFMobileSpecialPageResourceBoilerplate + array(
+ 'dependencies' => array(
+ 'mobile.stable'
+ ),
'scripts' => array(
'javascripts/specials/notifications.js',
),
@@ -1119,10 +1115,7 @@
'mobile.special.uploads.scripts' => $wgMFMobileResourceBoilerplate +
array(
'dependencies' => array(
- 'mobile.stable.styles',
- 'mobile.stable.common',
- 'mobile.templates',
- 'mobile.loggingSchemas',
+ 'mobile.stable'
),
'templates' => array(
'specials/uploads/photo',
--
To view, visit https://gerrit.wikimedia.org/r/147340
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib9054ac6842de4e73f3f8c34d1a5546bfe0dcef4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Kaldari <rkald...@wikimedia.org>
Gerrit-Reviewer: Awjrichards <aricha...@wikimedia.org>
Gerrit-Reviewer: JGonera <jgon...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
