Taueres has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/147903

Change subject: api.php: Use $wgRequest to retrieve User-agent string
......................................................................

api.php: Use $wgRequest to retrieve User-agent string

api.php was directly accessing $_SERVER superglobal.
It should use WebRequest wrapper object instead.

Change-Id: I244fb7a35476e9a35a5dc97f898d39c82c54b7fa
---
M api.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/03/147903/1

diff --git a/api.php b/api.php
index e8a911e..80abc35 100644
--- a/api.php
+++ b/api.php
@@ -104,7 +104,7 @@
                wfTimestamp( TS_MW ),
                $endtime - $starttime,
                $wgRequest->getIP(),
-               $_SERVER['HTTP_USER_AGENT']
+               $wgRequest->getHeader( 'User-agent' )
        );
        $items[] = $wgRequest->wasPosted() ? 'POST' : 'GET';
        if ( $processor ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/147903
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I244fb7a35476e9a35a5dc97f898d39c82c54b7fa
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Taueres <santoro....@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to