Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/147993
Change subject: Revert "Adding a bit more documentation to mw.loader.using"
......................................................................
Revert "Adding a bit more documentation to mw.loader.using"
This isn't relevant or specific to mw.loader.using. All of ResourceLoader
revolves around this idea. If two separate modules have a common
dependency, that's not loaded twice either. Whether they were passed to
loader.using(), loader.load(), or as dependencies, it doesn't matter.
The callback executes when the requires modules are ready. The
documentation never said it would load them on demand, so this bit of
supposed clarification only leads functions as noise in my opinion.
Perhaps we need to clarify elsewhere in the documentation for mw.loader
as a whole this concept, but not in this method in this way.
This reverts commit 657fab8d8388a475d850d84d8244da5e0ccfa8e7.
Change-Id: I30b3d6769f72aaab47c0b987bbb58898612206bd
---
M resources/src/mediawiki/mediawiki.js
1 file changed, 0 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/93/147993/1
diff --git a/resources/src/mediawiki/mediawiki.js
b/resources/src/mediawiki/mediawiki.js
index 4d1d563..12888bd 100644
--- a/resources/src/mediawiki/mediawiki.js
+++ b/resources/src/mediawiki/mediawiki.js
@@ -1698,9 +1698,6 @@
/**
* Execute a function as soon as one or more
required modules are ready.
*
- * If the required modules are already loaded,
the function will be
- * executed immediately and the modules will
not be reloaded.
- *
* Example of inline dependency on OOjs:
*
* mw.loader.using( 'oojs', function () {
--
To view, visit https://gerrit.wikimedia.org/r/147993
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I30b3d6769f72aaab47c0b987bbb58898612206bd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle <krinklem...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
