Ottomata has submitted this change and it was merged. Change subject: Add test to guard against encoding mangling of filter ......................................................................
Add test to guard against encoding mangling of filter Bug: 58316 Change-Id: Idd75710c55562a59da26893e2554c046f7129c1e --- M tests/test.sh 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Ottomata: Verified; Looks good to me, approved jenkins-bot: Verified diff --git a/tests/test.sh b/tests/test.sh index 871061a..258c95e 100755 --- a/tests/test.sh +++ b/tests/test.sh @@ -129,6 +129,13 @@ assert_counted "http://en.wikipedia.org/wiki/Special:CentralAutoLogin"; "en" "Special:CentralAutoLogin" assert_counted "http://en.wikipedia.org/wiki/Special:CentralAutoLoginX/Countworthy"; "en" "Special:CentralAutoLoginX/Countworthy" +# Around Bug 58316 people asked in private whether maybe +# webstatscollector mangles encoding. So let's make sure +# webstatscollector does not mangle encoding. +assert_counted 'http://en.wikipedia.org/wiki/Robinson_Can%C3%B3' 'en' 'Robinson_Can%C3%B3' +assert_counted 'http://en.wikipedia.org/wiki/Robinson_Can\xC3\xB3' 'en' 'Robinson_Can\xC3\xB3' +assert_counted 'http://en.wikipedia.org/wiki/Robinson_Canó' 'en' 'Robinson_Canó' + # -- printing statistics ------------------------------------------------------- TESTS_FAILED=$((TESTS-TESTS_GOOD)) -- To view, visit https://gerrit.wikimedia.org/r/103241 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idd75710c55562a59da26893e2554c046f7129c1e Gerrit-PatchSet: 2 Gerrit-Project: analytics/webstatscollector Gerrit-Branch: master Gerrit-Owner: QChris <[email protected]> Gerrit-Reviewer: Ottomata <[email protected]> Gerrit-Reviewer: Qgil <[email protected]> Gerrit-Reviewer: Stefan.petrea <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
