Ejegg has submitted this change and it was merged.
Change subject: simplify calling signature
......................................................................
simplify calling signature
Change-Id: I1fe0627900f8dc5b52912d45b1656f532042fe27
---
M sites/all/modules/recurring_globalcollect/recurring_globalcollect.module
M sites/all/modules/wmf_civicrm/recurring.inc
2 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Ejegg: Looks good to me, approved
jenkins-bot: Verified
diff --git
a/sites/all/modules/recurring_globalcollect/recurring_globalcollect.module
b/sites/all/modules/recurring_globalcollect/recurring_globalcollect.module
index 44459e0..0c679c5 100644
--- a/sites/all/modules/recurring_globalcollect/recurring_globalcollect.module
+++ b/sites/all/modules/recurring_globalcollect/recurring_globalcollect.module
@@ -373,7 +373,7 @@
$transaction = WmfTransaction::from_unique_id(
$contribution_recur['trxn_id'] );
- $initial_contribution = wmf_civicrm_get_initial_recurring_contribution(
$contribution_recur );
+ $initial_contribution = wmf_civicrm_get_initial_recurring_contribution(
$contribution_recur['id'] );
$contact = array(
'id' => $contribution_recur['contact_id'],
diff --git a/sites/all/modules/wmf_civicrm/recurring.inc
b/sites/all/modules/wmf_civicrm/recurring.inc
index 2a05dc7..5b0dacd 100644
--- a/sites/all/modules/wmf_civicrm/recurring.inc
+++ b/sites/all/modules/wmf_civicrm/recurring.inc
@@ -369,11 +369,11 @@
/**
* Get the first contribution in a recurring series
*
- * @param array $contribution_recur
+ * @param integer $contribution_recur_id
*
* @return array|false $contribution
*/
-function wmf_civicrm_get_initial_recurring_contribution( $contribution_recur )
{
+function wmf_civicrm_get_initial_recurring_contribution(
$contribution_recur_id ) {
$sql = "
SELECT * FROM civicrm_contribution
WHERE contribution_recur_id = %1
@@ -381,7 +381,7 @@
LIMIT 1";
$res = CRM_Core_DAO::executeQuery( $sql, array(
- '1' => array( $contribution_recur['id'], 'Integer' ),
+ '1' => array( $contribution_recur_id, 'Integer' ),
) );
$out = wmf_civicrm_dao_to_list( $res );
--
To view, visit https://gerrit.wikimedia.org/r/146978
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1fe0627900f8dc5b52912d45b1656f532042fe27
Gerrit-PatchSet: 2
Gerrit-Project: wikimedia/fundraising/crm
Gerrit-Branch: master
Gerrit-Owner: Awight <[email protected]>
Gerrit-Reviewer: Awight <[email protected]>
Gerrit-Reviewer: Ejegg <[email protected]>
Gerrit-Reviewer: Katie Horn <[email protected]>
Gerrit-Reviewer: Mwalker <[email protected]>
Gerrit-Reviewer: Ssmith <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
