Withoutaname has uploaded a new change for review.
https://gerrit.wikimedia.org/r/148276
Change subject: Remove functions deprecated since 1.19 from EditPage.php
......................................................................
Remove functions deprecated since 1.19 from EditPage.php
Specifically functions blockedPage(), noCreatePermission(), readOnlyPage()
and userNotLoggedInPage().
Change-Id: I3f8b16037d15a8b743dff975a8d7fe2b531a40d9
---
M RELEASE-NOTES-1.24
M includes/EditPage.php
2 files changed, 2 insertions(+), 55 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/76/148276/1
diff --git a/RELEASE-NOTES-1.24 b/RELEASE-NOTES-1.24
index ead5196..61545ac 100644
--- a/RELEASE-NOTES-1.24
+++ b/RELEASE-NOTES-1.24
@@ -265,7 +265,8 @@
* Removed maintenance script importTextFile.php. Use edit.php script instead.
* A _from_namespace field has been added to the templatelinks, pagelinks,
and filelinks tables. Run update.php to apply this change to the schema.
-
+* Removed functions blockedPage(), noCreatePermission(), readOnlyPage() and
+ userNotLoggedInPage() from EditPage.php. (deprecated since 1.19)
==== Renamed classes ====
* CLDRPluralRuleConverter_Expression to CLDRPluralRuleConverterExpression
diff --git a/includes/EditPage.php b/includes/EditPage.php
index a8a6811..1669668 100644
--- a/includes/EditPage.php
+++ b/includes/EditPage.php
@@ -644,26 +644,6 @@
}
/**
- * Show a read-only error
- * Parameters are the same as OutputPage:readOnlyPage()
- * Redirect to the article page if redlink=1
- * @deprecated since 1.19; use displayPermissionsError() instead
- */
- function readOnlyPage( $source = null, $protected = false, $reasons =
array(), $action = null ) {
- wfDeprecated( __METHOD__, '1.19' );
-
- global $wgRequest, $wgOut;
- if ( $wgRequest->getBool( 'redlink' ) ) {
- // The edit page was reached via a red link.
- // Redirect to the article page and let them click the
edit tab if
- // they really want a permission error.
- $wgOut->redirect( $this->mTitle->getFullURL() );
- } else {
- $wgOut->readOnlyPage( $source, $protected, $reasons,
$action );
- }
- }
-
- /**
* Should we show a preview when the edit form is first shown?
*
* @return bool
@@ -3895,40 +3875,6 @@
#. Xml::element( 'category', null,
$categories )
);
echo $s;
- }
-
- /**
- * Call the stock "user is blocked" page
- *
- * @deprecated since 1.19; throw an exception directly instead
- */
- function blockedPage() {
- wfDeprecated( __METHOD__, '1.19' );
- global $wgUser;
-
- throw new UserBlockedError( $wgUser->getBlock() );
- }
-
- /**
- * Produce the stock "please login to edit pages" page
- *
- * @deprecated since 1.19; throw an exception directly instead
- */
- function userNotLoggedInPage() {
- wfDeprecated( __METHOD__, '1.19' );
- throw new PermissionsError( 'edit' );
- }
-
- /**
- * Show an error page saying to the user that he has insufficient
permissions
- * to create a new page
- *
- * @deprecated since 1.19; throw an exception directly instead
- */
- function noCreatePermission() {
- wfDeprecated( __METHOD__, '1.19' );
- $permission = $this->mTitle->isTalkPage() ? 'createtalk' :
'createpage';
- throw new PermissionsError( $permission );
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/148276
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3f8b16037d15a8b743dff975a8d7fe2b531a40d9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Withoutaname <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits