Legoktm has uploaded a new change for review.
https://gerrit.wikimedia.org/r/148299
Change subject: More jshint fixes, also add .jshintrc
......................................................................
More jshint fixes, also add .jshintrc
Bug: 68335
Change-Id: I7a5fc29f9cff6e28fd765daf1a4f8093b3cdb8ac
---
A .jshintrc
M nimbus/Menu.js
2 files changed, 33 insertions(+), 7 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Nimbus
refs/changes/99/148299/1
diff --git a/.jshintrc b/.jshintrc
new file mode 100644
index 0000000..180ac6a
--- /dev/null
+++ b/.jshintrc
@@ -0,0 +1,26 @@
+{
+ /* Common */
+
+ // Enforcing
+ "camelcase": false,
+ "curly": true,
+ "eqeqeq": true,
+ "immed": true,
+ "latedef": true,
+ "newcap": true,
+ "noarg": true,
+ "noempty": true,
+ "nonew": true,
+ "quotmark": "single",
+ "trailing": true,
+ "undef": true,
+ "unused": true,
+ // Legacy
+ "onevar": true,
+
+ /* Local */
+ "predef": [
+ "mediaWiki",
+ "jQuery"
+ ]
+}
diff --git a/nimbus/Menu.js b/nimbus/Menu.js
index 9a169be..a3a49ba 100644
--- a/nimbus/Menu.js
+++ b/nimbus/Menu.js
@@ -4,7 +4,7 @@
* @file
* @author Jack Phoenix <[email protected]> - cleanup & removal of YUI
dependency, etc.
*/
-/* global getElementsByClassName, menuitem_array, submenuitem_array */
+/* global getElementsByClassName, menuitem_array, submenuitem_array, window,
document, setTimeout, clearTimeout */
var NimbusSkin = {
last_clicked: '',
m_timer: '',
@@ -47,7 +47,7 @@
editMenuToggle: function() {
var submenu = document.getElementById( 'edit-sub-menu-id' );
- if( submenu.style.display == 'block' ) {
+ if( submenu.style.display === 'block' ) {
submenu.style.display = 'none';
} else {
submenu.style.display = 'block';
@@ -94,8 +94,8 @@
if(
NimbusSkin.last_displayed === '' ||
- ( ( sub_menu_item.indexOf( NimbusSkin.last_displayed )
!= -1 ) &&
- ( sub_menu_item != NimbusSkin.last_displayed ) )
+ ( ( sub_menu_item.indexOf( NimbusSkin.last_displayed )
!== -1 ) &&
+ ( sub_menu_item !== NimbusSkin.last_displayed )
)
)
{
NimbusSkin.do_menuItemAction( item );
@@ -105,7 +105,7 @@
var the_last_displayed;
while( !exit && NimbusSkin.displayed_menus.length > 0 )
{
the_last_displayed =
NimbusSkin.displayed_menus.pop();
- if( ( sub_menu_item.indexOf( the_last_displayed
) == -1 ) ) {
+ if( ( sub_menu_item.indexOf( the_last_displayed
) === -1 ) ) {
NimbusSkin.doClear( the_last_displayed,
'' );
} else {
NimbusSkin.displayed_menus.push(
the_last_displayed );
@@ -254,7 +254,7 @@
},
show_more_category: function( el ) {
- if( NimbusSkin.show == 'false' ) {
+ if( NimbusSkin.show === 'false' ) {
document.getElementById( el ).style.display = 'block';
NimbusSkin.show = 'true';
} else {
@@ -264,7 +264,7 @@
},
show_actions: function( el, type ) {
- if( type == 'show' ) {
+ if( type === 'show' ) {
clearTimeout( NimbusSkin._hide_timer );
if( !NimbusSkin._shown ) {
jQuery( '#more-tab' ).removeClass(
'more-tab-off' ).addClass( 'more-tab-on' );
--
To view, visit https://gerrit.wikimedia.org/r/148299
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7a5fc29f9cff6e28fd765daf1a4f8093b3cdb8ac
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Nimbus
Gerrit-Branch: master
Gerrit-Owner: Legoktm <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
