Henning Snater has submitted this change and it was merged. Change subject: Introduced new $.NativeEventHandler and its documentation and tests ......................................................................
Introduced new $.NativeEventHandler and its documentation and tests Allows to fabricate functions which initially throw an event which can be canceled by jQueryEvent.preventDefault(). This allows us to create more generic event handling without having to care too much about those advanced features within the functions triggering the event. other event related changes in this change set: * Using jQuery.NativeEventHandler for wb.ui.Tooltip.prototype.hide now. * Using jQuery.NativeEventHandler for wb.ui.PropertyEditTool.EditableValue.prototype.showError now. * Implemented a ObservableObject.triggerHandler() * Refactored some of the existing events to use ObservableObject trigger functions * Using ObservableObject with wb.ui.Toolbar now * Moved event documentations for all of the global wikibase events to wikibase.js * Renamed ...eventRelatedExtensions.js file to ...ObservableObject.js - patch set 2: minor corrections Change-Id: I0ccdea99a5503624e0832b7a0adbfbf66056e5d3 --- M lib/WikibaseLib.hooks.php M lib/resources/Resources.php M lib/resources/wikibase.js M lib/resources/wikibase.ui.Base.js M lib/resources/wikibase.ui.PropertyEditTool.EditableValue.Interface.js M lib/resources/wikibase.ui.PropertyEditTool.EditableValue.js M lib/resources/wikibase.ui.Toolbar.Label.js M lib/resources/wikibase.ui.Toolbar.js M lib/resources/wikibase.ui.Tooltip.Extension.js M lib/resources/wikibase.ui.Tooltip.js R lib/resources/wikibase.utilities/wikibase.utilities.ObservableObject.js M lib/resources/wikibase.utilities/wikibase.utilities.jQuery.js M lib/resources/wikibase.utilities/wikibase.utilities.js M lib/tests/qunit/wikibase.utilities/wikibase.utilities.ObservableObject.tests.js A lib/tests/qunit/wikibase.utilities/wikibase.utilities.jQuery.NativeEventHandler.tests.js 15 files changed, 552 insertions(+), 55 deletions(-) Approvals: Henning Snater: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/27994 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0ccdea99a5503624e0832b7a0adbfbf66056e5d3 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Daniel Werner <daniel.wer...@wikimedia.de> Gerrit-Reviewer: Daniel Werner <daniel.wer...@wikimedia.de> Gerrit-Reviewer: Henning Snater <henning.sna...@wikimedia.de> Gerrit-Reviewer: Jeroen De Dauw <jeroended...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
