Reedy has uploaded a new change for review.
https://gerrit.wikimedia.org/r/148514
Change subject: Swap MessageCache::get closure to global function to fix
segfault
......................................................................
Swap MessageCache::get closure to global function to fix segfault
Stopping Database Dumps from running
Change-Id: I1b34716cd981acc72ab4f3ad0036620fb1d56a58
---
M WikimediaMessages.php
1 file changed, 9 insertions(+), 1 deletion(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikimediaMessages
refs/changes/14/148514/1
diff --git a/WikimediaMessages.php b/WikimediaMessages.php
index d0a2466..3120c39 100644
--- a/WikimediaMessages.php
+++ b/WikimediaMessages.php
@@ -107,12 +107,20 @@
return true;
};
+$wgHooks['MessageCache::get'][] = 'WikimediaMessagesMessageCacheGet';
+
/**
* When core requests certain messages, change the key to a Wikimedia version.
*
+ * @note Don't make this a closure, it causes the Database Dumps to fail.
+ * See https://bugs.php.net/bug.php?id=52144
+ *
+ * mwscript getSlaveServer.php --wiki='dewiki' --group=dump --globals
+ * print_r( $GLOBALS['wgHooks']['MessageCache::get'] );
+ *
* @param String &$lcKey message key to check and possibly convert
*/
-$wgHooks['MessageCache::get'][] = function( &$lcKey ) {
+function WikimediaMessagesMessageCacheGet( &$lcKey ) {
global $wgLanguageCode;
static $keys = array(
--
To view, visit https://gerrit.wikimedia.org/r/148514
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1b34716cd981acc72ab4f3ad0036620fb1d56a58
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikimediaMessages
Gerrit-Branch: master
Gerrit-Owner: Reedy <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
