Withoutaname has uploaded a new change for review. https://gerrit.wikimedia.org/r/148524
Change subject: Remove old maintenance script eval.php ...................................................................... Remove old maintenance script eval.php Change-Id: Iafd6a5fb3576de93926ccda0f5e093adf39a8f94 --- M RELEASE-NOTES-1.24 D maintenance/eval.php 2 files changed, 3 insertions(+), 97 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/24/148524/1 diff --git a/RELEASE-NOTES-1.24 b/RELEASE-NOTES-1.24 index ead5196..2333c49 100644 --- a/RELEASE-NOTES-1.24 +++ b/RELEASE-NOTES-1.24 @@ -265,7 +265,9 @@ * Removed maintenance script importTextFile.php. Use edit.php script instead. * A _from_namespace field has been added to the templatelinks, pagelinks, and filelinks tables. Run update.php to apply this change to the schema. - +* Removed maintenance script eval.php. PHP's natively implemented interactive + shell, available since PHP version 5.1.0, is always preferred over eval. + See https://php.net/manual/en/features.commandline.interactive.php ==== Renamed classes ==== * CLDRPluralRuleConverter_Expression to CLDRPluralRuleConverterExpression diff --git a/maintenance/eval.php b/maintenance/eval.php deleted file mode 100644 index 51f2cac..0000000 --- a/maintenance/eval.php +++ /dev/null @@ -1,96 +0,0 @@ -<?php -/** - * This script lets a command-line user start up the wiki engine and then poke - * about by issuing PHP commands directly. - * - * Unlike eg Python, you need to use a 'return' statement explicitly for the - * interactive shell to print out the value of the expression. Multiple lines - * are evaluated separately, so blocks need to be input without a line break. - * Fatal errors such as use of undeclared functions can kill the shell. - * - * To get decent line editing behavior, you should compile PHP with support - * for GNU readline (pass --with-readline to configure). - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along - * with this program; if not, write to the Free Software Foundation, Inc., - * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. - * http://www.gnu.org/copyleft/gpl.html - * - * @file - * @ingroup Maintenance - */ - -$optionsWithArgs = array( 'd' ); - -/** */ -require_once __DIR__ . "/commandLine.inc"; - -if ( isset( $options['d'] ) ) { - $d = $options['d']; - if ( $d > 0 ) { - $wgDebugLogFile = '/dev/stdout'; - } - if ( $d > 1 ) { - $lb = wfGetLB(); - $serverCount = $lb->getServerCount(); - for ( $i = 0; $i < $serverCount; $i++ ) { - $server = $lb->getServerInfo( $i ); - $server['flags'] |= DBO_DEBUG; - $lb->setServerInfo( $i, $server ); - } - } - if ( $d > 2 ) { - $wgDebugFunctionEntry = true; - } -} - -$useReadline = function_exists( 'readline_add_history' ) - && Maintenance::posix_isatty( 0 /*STDIN*/ ); - -if ( $useReadline ) { - $historyFile = isset( $_ENV['HOME'] ) ? - "{$_ENV['HOME']}/.mweval_history" : "$IP/maintenance/.mweval_history"; - readline_read_history( $historyFile ); -} - -$e = null; // PHP exception -while ( ( $line = Maintenance::readconsole() ) !== false ) { - if ( $e && !preg_match( '/^(exit|die);?$/', $line ) ) { - // Internal state may be corrupted or fatals may occur later due - // to some object not being set. Don't drop out of eval in case - // lines were being pasted in (which would then get dumped to the shell). - // Instead, just absorb the remaning commands. Let "exit" through per DWIM. - echo "Exception was thrown before; please restart eval.php\n"; - continue; - } - if ( $useReadline ) { - readline_add_history( $line ); - readline_write_history( $historyFile ); - } - try { - $val = eval( $line . ";" ); - } catch ( Exception $e ) { - echo "Caught exception " . get_class( $e ) . - ": {$e->getMessage()}\n" . $e->getTraceAsString() . "\n"; - continue; - } - if ( wfIsHHVM() || is_null( $val ) ) { - echo "\n"; - } elseif ( is_string( $val ) || is_numeric( $val ) ) { - echo "$val\n"; - } else { - var_dump( $val ); - } -} - -print "\n"; -- To view, visit https://gerrit.wikimedia.org/r/148524 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iafd6a5fb3576de93926ccda0f5e093adf39a8f94 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Withoutaname <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
