Catrope has uploaded a new change for review.
https://gerrit.wikimedia.org/r/148549
Change subject: Stop conditionally registering oojs and oojs-ui
......................................................................
Stop conditionally registering oojs and oojs-ui
We already have wfUseMW( '1.24wmf6' ) so we don't need this any more.
The messages list for oojs-ui had gotten out of date, and rather than
fixing it I figured we should just remove this conditional registration
code altogether.
Change-Id: If0610beb2df8bd85aeba136530a84a793e3dda64
---
M VisualEditor.hooks.php
1 file changed, 1 insertion(+), 36 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/49/148549/1
diff --git a/VisualEditor.hooks.php b/VisualEditor.hooks.php
index 4397138..5e7fb35 100644
--- a/VisualEditor.hooks.php
+++ b/VisualEditor.hooks.php
@@ -419,10 +419,7 @@
}
/**
- * Conditionally register the oojs and oojs-ui modules, in case they've
already been registered
- * by a more recent version of MediaWiki core.
- *
- * Also conditionally register the jquery.uls.data and jquery.i18n
modules, in case they've already
+ * Conditionally register the jquery.uls.data and jquery.i18n modules,
in case they've already
* been registered by the UniversalLanguageSelector extension.
*
* @param ResourceLoader $resourceLoader
@@ -432,38 +429,6 @@
global $wgResourceModules, $wgVisualEditorResourceTemplate;
$libModules = array(
- 'oojs' => $wgVisualEditorResourceTemplate + array(
- 'scripts' => array(
- 'lib/ve/lib/oojs/oojs.js',
- ),
- 'targets' => array( 'desktop', 'mobile' ),
- ),
- 'oojs-ui' => $wgVisualEditorResourceTemplate + array(
- 'scripts' => array(
- 'lib/ve/lib/oojs-ui/oojs-ui.js',
- ),
- 'styles' => array(
- 'lib/ve/lib/oojs-ui/oojs-ui.svg.css',
- ),
- 'skinStyles' => array(
- 'default' =>
'lib/ve/lib/oojs-ui/oojs-ui-apex.css',
- ),
- 'messages' => array(
- 'ooui-dialog-action-close',
- 'ooui-outline-control-move-down',
- 'ooui-outline-control-move-up',
- 'ooui-outline-control-remove',
- 'ooui-toolbar-more',
- 'ooui-dialog-confirm-title',
- 'ooui-dialog-confirm-default-prompt',
- 'ooui-dialog-confirm-default-ok',
- 'ooui-dialog-confirm-default-cancel'
- ),
- 'dependencies' => array(
- 'oojs'
- ),
- 'targets' => array( 'desktop', 'mobile' ),
- ),
'jquery.uls.data' => $wgVisualEditorResourceTemplate +
array(
'scripts' => array(
'lib/ve/lib/jquery.uls/src/jquery.uls.data.js',
--
To view, visit https://gerrit.wikimedia.org/r/148549
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If0610beb2df8bd85aeba136530a84a793e3dda64
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
