jenkins-bot has submitted this change and it was merged.
Change subject: Followup b6cc76d4: call parent's onSetup/onTeardown
......................................................................
Followup b6cc76d4: call parent's onSetup/onTeardown
Otherwise .data( 'view' ) doesn't get set.
Bug: 68415
Change-Id: Id4d8351f6d1d3193de6279bddcfe18d09b3db245
---
M modules/ve-mw/ce/nodes/ve.ce.MWReferenceNode.js
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Mooeypoo: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve-mw/ce/nodes/ve.ce.MWReferenceNode.js
b/modules/ve-mw/ce/nodes/ve.ce.MWReferenceNode.js
index cff126e..b682ec1 100644
--- a/modules/ve-mw/ce/nodes/ve.ce.MWReferenceNode.js
+++ b/modules/ve-mw/ce/nodes/ve.ce.MWReferenceNode.js
@@ -59,6 +59,7 @@
* @method
*/
ve.ce.MWReferenceNode.prototype.onSetup = function () {
+ ve.ce.MWReferenceNode.super.prototype.onSetup.call( this );
this.internalList.connect( this, { 'update': 'onInternalListUpdate' } );
};
@@ -70,6 +71,8 @@
// As we are listening to the internal list, we need to make sure
// we remove the listeners when this object is removed from the document
this.internalList.disconnect( this );
+
+ ve.ce.MWReferenceNode.super.prototype.onTeardown.call( this );
};
/**
--
To view, visit https://gerrit.wikimedia.org/r/148559
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id4d8351f6d1d3193de6279bddcfe18d09b3db245
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
Gerrit-Reviewer: Mooeypoo <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
