Spage has uploaded a new change for review.
https://gerrit.wikimedia.org/r/148583
Change subject: Don't render popup on "javascript:..." links.
......................................................................
Don't render popup on "javascript:..." links.
Also some doc.
Bug: 68417
Change-Id: Ib8b53f131f05477adfa12c8284f624d5c70d995f
---
M resources/ext.popups.core.js
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups
refs/changes/83/148583/1
diff --git a/resources/ext.popups.core.js b/resources/ext.popups.core.js
index b8e3c41..dbf73d7 100644
--- a/resources/ext.popups.core.js
+++ b/resources/ext.popups.core.js
@@ -122,7 +122,7 @@
};
/**
- * Register the hover event on links
+ * Register a hover event that may render a popup on an appropriate
link.
*
* @method setupTriggers
*/
@@ -132,11 +132,14 @@
$this = $( this ),
href = $this.attr( 'href' );
+ // No popup if scrolling or on certain kinds of links.
if (
mw.popups.scrolled || // Prevents hovering on
popups while scrolling
href.indexOf( '?' ) !== -1 ||
+ href.indexOf( 'javascript:' ) === 0 ||
href.indexOf( location.origin +
location.pathname + '#' ) === 0
) {
+ // TODO No popup for this, but removeTooltips()
has already blanked the title.
return;
}
--
To view, visit https://gerrit.wikimedia.org/r/148583
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib8b53f131f05477adfa12c8284f624d5c70d995f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Spage <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
