Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/148769
Change subject: Standardize regex delimiter in doc of $wgWhitelistReadRegexp
......................................................................
Standardize regex delimiter in doc of $wgWhitelistReadRegexp
@ is a rare used regex delimiter, change it to /
/ is also used some lines above (inside the same doc)
Also adjust the test
Change-Id: I6a18d295b9ca45098645d3bacafe5913d6957f89
---
M includes/DefaultSettings.php
M tests/phpunit/includes/TitleTest.php
2 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/69/148769/1
diff --git a/includes/DefaultSettings.php b/includes/DefaultSettings.php
index 86b7533..5145d39 100644
--- a/includes/DefaultSettings.php
+++ b/includes/DefaultSettings.php
@@ -4250,7 +4250,7 @@
* @par Example:
* To allow reading any page starting with 'User' regardless of the case:
* @code
- * $wgWhitelistReadRegexp = array( "@^UsEr.*@i" );
+ * $wgWhitelistReadRegexp = array( "/^UsEr.*/i" );
* @endcode
* Will allow both [[User is banned]] and [[User:JohnDoe]]
*
diff --git a/tests/phpunit/includes/TitleTest.php
b/tests/phpunit/includes/TitleTest.php
index 6871582..80d59ed 100644
--- a/tests/phpunit/includes/TitleTest.php
+++ b/tests/phpunit/includes/TitleTest.php
@@ -385,8 +385,8 @@
array( '/MiC ChEcK/i', 'mic check', 'read', $ALLOWED ),
// From DefaultSettings.php:
- array( "@^UsEr.*@i", 'User is banned', 'read', $ALLOWED
),
- array( "@^UsEr.*@i", 'User:John Doe', 'read', $ALLOWED
),
+ array( "/^UsEr.*/i", 'User is banned', 'read', $ALLOWED
),
+ array( "/^UsEr.*/i", 'User:John Doe', 'read', $ALLOWED
),
// With namespaces:
array( '/^Special:NewPages$/', 'Special:NewPages',
'read', $ALLOWED ),
--
To view, visit https://gerrit.wikimedia.org/r/148769
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6a18d295b9ca45098645d3bacafe5913d6957f89
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <umherirrender_de...@web.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
