Umherirrender has uploaded a new change for review. https://gerrit.wikimedia.org/r/149028
Change subject: Avoid function calls in a FOR loop test part ...................................................................... Avoid function calls in a FOR loop test part Change-Id: I64d9ba96797085b6f54658218404a02d4087ceaf --- M thumb.php 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/28/149028/1 diff --git a/thumb.php b/thumb.php index 9a4b332..2d7cca7 100644 --- a/thumb.php +++ b/thumb.php @@ -520,7 +520,8 @@ $repo = RepoGroup::singleton()->getLocalRepo(); $hashDirReg = $subdirReg = ''; - for ( $i = 0; $i < $repo->getHashLevels(); $i++ ) { + $hashLevels = $repo->getHashLevels(); + for ( $i = 0; $i < $hashLevels; $i++ ) { $subdirReg .= '[0-9a-f]'; $hashDirReg .= "$subdirReg/"; } -- To view, visit https://gerrit.wikimedia.org/r/149028 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I64d9ba96797085b6f54658218404a02d4087ceaf Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Umherirrender <umherirrender_de...@web.de> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits