Subramanya Sastry has submitted this change and it was merged. Change subject: Fix another replace bug in the LinkHandler ......................................................................
Fix another replace bug in the LinkHandler JavaScript replace not being global by default is evidently not the most intuitive choice and causes a few subtle bugs. Went through all replace uses and found one more bug. Also removed the old unquote method which also used replace incorrectly. Was not used anyway. Change-Id: Id7602800ccd6fa2283a3f0afc9dd22a9c1e3f4e2 --- M js/lib/ext.core.LinkHandler.js M js/lib/pegTokenizer.pegjs.txt 2 files changed, 1 insertion(+), 8 deletions(-) Approvals: Subramanya Sastry: Verified; Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/28043 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id7602800ccd6fa2283a3f0afc9dd22a9c1e3f4e2 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Parsoid Gerrit-Branch: master Gerrit-Owner: GWicke <[email protected]> Gerrit-Reviewer: Subramanya Sastry <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
