Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/149249
Change subject: Improve test in SpecialUnconnectedPagesTest
......................................................................
Improve test in SpecialUnconnectedPagesTest
Change-Id: Ibd7865cd81d293d3ad648a1ac92ae7fc8e4da714
---
M client/tests/phpunit/includes/specials/SpecialUnconnectedPagesTest.php
1 file changed, 2 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/49/149249/1
diff --git
a/client/tests/phpunit/includes/specials/SpecialUnconnectedPagesTest.php
b/client/tests/phpunit/includes/specials/SpecialUnconnectedPagesTest.php
index d78f52a..db25407 100644
--- a/client/tests/phpunit/includes/specials/SpecialUnconnectedPagesTest.php
+++ b/client/tests/phpunit/includes/specials/SpecialUnconnectedPagesTest.php
@@ -24,10 +24,8 @@
return new SpecialUnconnectedPages();
}
- public function testExecute( ) {
- //TODO: Actually verify that the output is correct.
- // Currently this just tests that there is no fatal error.
- list( $output, ) = $this->executeSpecialPage( '' );
+ public function testExecuteDoesNotCauseFatalError() {
+ $this->executeSpecialPage( '' );
$this->assertTrue( true, 'Calling execute without any subpage
value' );
}
--
To view, visit https://gerrit.wikimedia.org/r/149249
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibd7865cd81d293d3ad648a1ac92ae7fc8e4da714
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <jeroended...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
