jenkins-bot has submitted this change and it was merged.
Change subject: Move bottom border to page actions
......................................................................
Move bottom border to page actions
When it doesn't exist, this line doesn't make sense and overlaps
the bottom border of the headings. e.g. Flow boards
Let's put it on the element it
should be on.
Change-Id: Id56b7efe23daa128f639397bc0a2d457f5f899c8
---
M less/common/pageactions.less
M less/tablet/common.less
2 files changed, 3 insertions(+), 6 deletions(-)
Approvals:
JGonera: Looks good to me, approved
Jdlrobson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/less/common/pageactions.less b/less/common/pageactions.less
index 7af2fa3..88276b5 100644
--- a/less/common/pageactions.less
+++ b/less/common/pageactions.less
@@ -17,13 +17,10 @@
border-bottom: dotted 1px #CACACA;
}
-.pre-content {
- // FIXME: Use a gray defined in variables e.g. @grayMediumLight
- border-bottom: solid 1px #CACACA;
-}
-
#page-actions {
@verticalMargin: 8px;
+ // FIXME: Use a gray defined in variables e.g. @grayMediumLight
+ border-bottom: solid 1px #CACACA;
padding: @verticalMargin @contentMargin @verticalMargin @contentMargin
- 8;
diff --git a/less/tablet/common.less b/less/tablet/common.less
index 6079042..57f0efa 100644
--- a/less/tablet/common.less
+++ b/less/tablet/common.less
@@ -19,7 +19,6 @@
.pre-content {
position: relative;
padding: 20px @contentPaddingTablet 0 @contentPaddingTablet;
- border: none;
#section_0 {
border-bottom: 1px solid @sectionBorderColor;
@@ -30,6 +29,7 @@
}
#page-actions {
+ border: none;
padding: 36px @contentPaddingTablet 0 0;
position: absolute;
right: 0;
--
To view, visit https://gerrit.wikimedia.org/r/148504
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id56b7efe23daa128f639397bc0a2d457f5f899c8
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
Gerrit-Reviewer: Awjrichards <[email protected]>
Gerrit-Reviewer: JGonera <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
