jenkins-bot has submitted this change and it was merged.
Change subject: Remove return value from QueryPage::execute
......................................................................
Remove return value from QueryPage::execute
The parent SpecialPage::execute also has no return and not all return
statements in QueryPage::execute actual return a value
Change-Id: If7a38ca5ed1107b6a5a740acae54295534950696
---
M includes/specialpage/QueryPage.php
1 file changed, 1 insertion(+), 4 deletions(-)
Approvals:
IAlex: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/specialpage/QueryPage.php
b/includes/specialpage/QueryPage.php
index 3a83d2b..b8fc05e 100644
--- a/includes/specialpage/QueryPage.php
+++ b/includes/specialpage/QueryPage.php
@@ -470,7 +470,6 @@
* This is the actual workhorse. It does everything needed to make a
* real, honest-to-gosh query page.
* @param string $par
- * @return int
*/
function execute( $par ) {
global $wgQueryCacheLimit, $wgDisableQueryPageUpdate;
@@ -488,7 +487,7 @@
if ( $this->isCached() && !$this->isCacheable() ) {
$out->addWikiMsg( 'querypage-disabled' );
- return 0;
+ return;
}
$out->setSyndicated( $this->isSyndicated() );
@@ -578,8 +577,6 @@
}
$out->addHTML( Xml::closeElement( 'div' ) );
-
- return min( $this->numRows, $this->limit ); # do not return the
one extra row, if exist
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/147989
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If7a38ca5ed1107b6a5a740acae54295534950696
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <umherirrender_de...@web.de>
Gerrit-Reviewer: Catrope <roan.katt...@gmail.com>
Gerrit-Reviewer: IAlex <coderev...@emsenhuber.ch>
Gerrit-Reviewer: Umherirrender <umherirrender_de...@web.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
