Siebrand has submitted this change and it was merged. Change subject: Lots of work on tests ......................................................................
Lots of work on tests * Renamed SuperUser to MockSuperUser and added to autoloader. * Renamed MessageGroupStatesUpdaterJob to have Test at the end, the tests were not run because it was missing from the filename. * Refactor ApiTranslationReview to hade doReview function. * Created MockWikiMessageGroup * Some cleanups, provides prefixed with provide*, static * Using the new setMwGlobals from core in favor of own hacks - this raises test dependency to 1.21 * MessageGroupStatesUpdaterJobTest was expanded to test that the hooks do fire and get processed. Change-Id: I403fee19988ddce678099fa736a6a4d0a1627eb5 --- M _autoload.php M api/ApiTranslationReview.php M tests/ApiGroupReviewTest.php D tests/MessageGroupStatesUpdaterJob.php A tests/MessageGroupStatesUpdaterJobTest.php R tests/MockSuperUser.php A tests/MockWikiMessageGroup.php M tests/PageTranslationTaggingTest.php M tests/SpecialPagesTest.php M utils/MessageGroupStates.php 10 files changed, 292 insertions(+), 192 deletions(-) Approvals: Nikerabbit: Verified Siebrand: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/28022 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I403fee19988ddce678099fa736a6a4d0a1627eb5 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Translate Gerrit-Branch: master Gerrit-Owner: Nikerabbit <niklas.laxst...@gmail.com> Gerrit-Reviewer: Nikerabbit <niklas.laxst...@gmail.com> Gerrit-Reviewer: Siebrand <siebr...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
