EBernhardson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/150011
Change subject: Fix wrong response from new-topic using redis
......................................................................
Fix wrong response from new-topic using redis
Change-Id: I6d81d4a1bc6745e9894ba525de258a970f3d8d94
---
M includes/Data/BufferedCache.php
1 file changed, 8 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow
refs/changes/11/150011/1
diff --git a/includes/Data/BufferedCache.php b/includes/Data/BufferedCache.php
index c46f853..8cc3648 100644
--- a/includes/Data/BufferedCache.php
+++ b/includes/Data/BufferedCache.php
@@ -35,7 +35,14 @@
* @return array
*/
public function getMulti( array $keys ) {
- return $this->cache->getMulti( $keys );
+ // The memcached BagOStuff returns only existing keys,
+ // but the redis BagOStuff puts a false for all keys
+ // it doesn't find. Resolve that inconsistency here
+ // by filtering all false values.
+ return array_filter(
+ $this->cache->getMulti( $keys ),
+ function( $value ) { return $value !== false; }
+ );
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/150011
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6d81d4a1bc6745e9894ba525de258a970f3d8d94
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: EBernhardson <ebernhard...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
