jenkins-bot has submitted this change and it was merged.
Change subject: Add at least one RTL language to the TestSites mock collection
......................................................................
Add at least one RTL language to the TestSites mock collection
When working on Wikibase/Wikidata we learned that it's always a
good idea to test with at least one right-to-left (RTL) language.
We prefer 'fa' (Farsi, the Persian language).
This change affects about 30 tests.
If they all succeed the change should be fine, right?
Change-Id: I11ded5ff98816e604da8fb92993834eb7dc99b99
---
M tests/phpunit/includes/site/TestSites.php
1 file changed, 16 insertions(+), 1 deletion(-)
Approvals:
Daniel Kinzler: Looks good to me, approved
Siebrand: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/tests/phpunit/includes/site/TestSites.php
b/tests/phpunit/includes/site/TestSites.php
index f224b7d..af314ba 100644
--- a/tests/phpunit/includes/site/TestSites.php
+++ b/tests/phpunit/includes/site/TestSites.php
@@ -72,7 +72,22 @@
$site->setLinkPath( "http://spamzz.test/testing/"; );
$sites[] = $site;
- foreach ( array( 'en', 'de', 'nl', 'sv', 'sr', 'no', 'nn' ) as
$langCode ) {
+ /**
+ * Add at least one right-to-left language (current RTL
languages in MediaWiki core are:
+ * aeb, ar, arc, arz, azb, bcc, bqi, ckb, dv, en_rtl, fa, glk,
he, khw, kk_arab, kk_cn,
+ * ks_arab, ku_arab, lrc, mzn, pnb, ps, sd, ug_arab, ur, yi).
+ */
+ $languageCodes = array(
+ 'de',
+ 'en',
+ 'fa', //right-to-left
+ 'nl',
+ 'nn',
+ 'no',
+ 'sr',
+ 'sv',
+ );
+ foreach ( $languageCodes as $langCode ) {
$site = new MediaWikiSite();
$site->setGlobalId( $langCode . 'wiki' );
$site->setGroup( 'wikipedia' );
--
To view, visit https://gerrit.wikimedia.org/r/135569
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I11ded5ff98816e604da8fb92993834eb7dc99b99
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
Gerrit-Reviewer: Addshore <addshorew...@gmail.com>
Gerrit-Reviewer: Aude <aude.w...@gmail.com>
Gerrit-Reviewer: Daniel Kinzler <daniel.kinz...@wikimedia.de>
Gerrit-Reviewer: Hashar <has...@free.fr>
Gerrit-Reviewer: Jeroen De Dauw <jeroended...@gmail.com>
Gerrit-Reviewer: Siebrand <siebr...@kitano.nl>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
