Gilles has uploaded a new change for review. https://gerrit.wikimedia.org/r/150223
Change subject: Add file extension to displayed title ...................................................................... Add file extension to displayed title Change-Id: Ibc6b2c341ef7f2dc139255a468418eaa01a91bd7 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/798 --- M resources/mmv/ui/mmv.ui.metadataPanel.js M tests/qunit/mmv/ui/mmv.ui.metadataPanel.test.js 2 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MultimediaViewer refs/changes/23/150223/1 diff --git a/resources/mmv/ui/mmv.ui.metadataPanel.js b/resources/mmv/ui/mmv.ui.metadataPanel.js index 8541d5f..a43eb8a 100644 --- a/resources/mmv/ui/mmv.ui.metadataPanel.js +++ b/resources/mmv/ui/mmv.ui.metadataPanel.js @@ -777,7 +777,7 @@ var panel = this, fileTitle = image.filePageTitle; - this.setFileTitle( fileTitle.getNameText() ); + this.setFileTitle( fileTitle.getMainText() ); this.setRepoDisplay( repoData ); this.setFilePageLink( imageData.descriptionUrl ); diff --git a/tests/qunit/mmv/ui/mmv.ui.metadataPanel.test.js b/tests/qunit/mmv/ui/mmv.ui.metadataPanel.test.js index 3bb5a1f..577bf2a 100644 --- a/tests/qunit/mmv/ui/mmv.ui.metadataPanel.test.js +++ b/tests/qunit/mmv/ui/mmv.ui.metadataPanel.test.js @@ -120,9 +120,9 @@ var gender, $qf = $( '#qunit-fixture' ), panel = new mw.mmv.ui.MetadataPanel( $qf, $( '<div>' ).appendTo( $qf ) ), - title = 'Foo bar', + title = 'Foo bar.jpg', image = { - filePageTitle : mw.Title.newFromText( 'File:' + title + '.jpg' ) + filePageTitle : mw.Title.newFromText( 'File:' + title ) }, imageData = { title: image.filePageTitle, -- To view, visit https://gerrit.wikimedia.org/r/150223 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibc6b2c341ef7f2dc139255a468418eaa01a91bd7 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MultimediaViewer Gerrit-Branch: master Gerrit-Owner: Gilles <gdu...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
