jenkins-bot has submitted this change and it was merged.
Change subject: Drop unused parameter from MonthNameUnlocalizer
......................................................................
Drop unused parameter from MonthNameUnlocalizer
Change-Id: Ia322f83dec6eaffcadb25fbacaf94944234e2a48
---
M lib/includes/parsers/DateTimeParser.php
M lib/includes/parsers/MonthNameUnlocalizer.php
M lib/tests/phpunit/parsers/MonthNameUnlocalizerTest.php
3 files changed, 3 insertions(+), 7 deletions(-)
Approvals:
WikidataJenkins: Verified
Addshore: Looks good to me, approved
jenkins-bot: Verified
diff --git a/lib/includes/parsers/DateTimeParser.php
b/lib/includes/parsers/DateTimeParser.php
index e965888..bdcfb4d 100644
--- a/lib/includes/parsers/DateTimeParser.php
+++ b/lib/includes/parsers/DateTimeParser.php
@@ -66,8 +66,7 @@
$this->getValueWithFixedSeparators(
$this->monthUnlocalizer->unlocalize(
trim( $value ),
- $options->getOption(
ValueParser::OPT_LANG ),
- new ParserOptions()
+ $options->getOption(
ValueParser::OPT_LANG )
)
)
);
diff --git a/lib/includes/parsers/MonthNameUnlocalizer.php
b/lib/includes/parsers/MonthNameUnlocalizer.php
index 990dd0a..6c0e216 100644
--- a/lib/includes/parsers/MonthNameUnlocalizer.php
+++ b/lib/includes/parsers/MonthNameUnlocalizer.php
@@ -3,7 +3,6 @@
namespace Wikibase\Lib\Parsers;
use Language;
-use ValueParsers\ParserOptions;
/**
* Class to unlocalize a month name in a date string using MediaWiki's
Language object.
@@ -22,11 +21,10 @@
*
* @param string $date Localized date string.
* @param string $languageCode
- * @param ParserOptions $options
*
* @return string
*/
- public function unlocalize( $date, $languageCode, ParserOptions
$options ) {
+ public function unlocalize( $date, $languageCode ) {
if ( $languageCode === 'en' ) {
return $date;
}
diff --git a/lib/tests/phpunit/parsers/MonthNameUnlocalizerTest.php
b/lib/tests/phpunit/parsers/MonthNameUnlocalizerTest.php
index 0c5b24b..e9b850a 100644
--- a/lib/tests/phpunit/parsers/MonthNameUnlocalizerTest.php
+++ b/lib/tests/phpunit/parsers/MonthNameUnlocalizerTest.php
@@ -100,9 +100,8 @@
*/
public function testUnlocalize( $localized, $languageCode, $expected ) {
$monthUnlocalizer = new MonthNameUnlocalizer();
- $options = new ParserOptions();
- $actual = $monthUnlocalizer->unlocalize( $localized,
$languageCode, $options );
+ $actual = $monthUnlocalizer->unlocalize( $localized,
$languageCode );
$this->assertEquals( $expected, $actual );
}
--
To view, visit https://gerrit.wikimedia.org/r/148114
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia322f83dec6eaffcadb25fbacaf94944234e2a48
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
Gerrit-Reviewer: Addshore <addshorew...@gmail.com>
Gerrit-Reviewer: Daniel Kinzler <daniel.kinz...@wikimedia.de>
Gerrit-Reviewer: Hoo man <h...@online.de>
Gerrit-Reviewer: Jeroen De Dauw <jeroended...@gmail.com>
Gerrit-Reviewer: WikidataJenkins <wikidata-servi...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
