jenkins-bot has submitted this change and it was merged.
Change subject: Let VE know if we are running on iOS
......................................................................
Let VE know if we are running on iOS
Scrolling to section in the editor has to be implemented differently
on iOS (scrolling within a div vs. scrolling the whole page).
Also, force hardware acceleration on .overlay-content to avoid rendering
bugs on iOS Safari.
Related changes (not hard dependencies):
* I6e47edfa8c3a3a46fd7a4f11e4a54955f3694b9b
* I518312b3a038f2e5c9cc2022c51fc4e1e63f599d
Change-Id: Ic1ba7c921f9adb9f535ee4c01aaca47e3e263994
---
M javascripts/modules/editor/VisualEditorOverlay.js
M less/common/Overlay.less
2 files changed, 9 insertions(+), 3 deletions(-)
Approvals:
Kaldari: Looks good to me, approved
jenkins-bot: Verified
diff --git a/javascripts/modules/editor/VisualEditorOverlay.js
b/javascripts/modules/editor/VisualEditorOverlay.js
index 79196cf..f18fdde 100644
--- a/javascripts/modules/editor/VisualEditorOverlay.js
+++ b/javascripts/modules/editor/VisualEditorOverlay.js
@@ -34,14 +34,14 @@
show: function() {
this._super();
if ( this.target === undefined ) {
- // FIXME: MobileViewTarget does not accept a
second argument
// FIXME: we have to initialize
MobileViewTarget after this.$el
// is attached to DOM, maybe we should attach
it earlier and hide
// overlays in a different way?
this.target = new ve.init.mw.MobileViewTarget(
this.$( '.surface' ), {
// || undefined so that scrolling is
not triggered for the lead (0) section
// (which has no header to scroll to)
- section: this.options.sectionId ||
undefined
+ section: this.options.sectionId ||
undefined,
+ isIos: M.isIos
} );
this.target.activating = true;
this.target.load();
diff --git a/less/common/Overlay.less b/less/common/Overlay.less
index c907d84..57595ac 100644
--- a/less/common/Overlay.less
+++ b/less/common/Overlay.less
@@ -311,8 +311,14 @@
}
.overlay-content {
- overflow-y: scroll; // has to be scroll, not auto
+ // has to be scroll, not auto
+ overflow-y: scroll;
-webkit-overflow-scrolling: touch;
+ // prevent disappearing after scrolling when
-webkit-overflow-scrolling: touch
+ // is used (http://stackoverflow.com/a/10170170)
+ * {
+ -webkit-transform: translate3d(0,0,0);
+ }
}
}
--
To view, visit https://gerrit.wikimedia.org/r/148888
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic1ba7c921f9adb9f535ee4c01aaca47e3e263994
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: JGonera <[email protected]>
Gerrit-Reviewer: Awjrichards <[email protected]>
Gerrit-Reviewer: Kaldari <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
