jenkins-bot has submitted this change and it was merged.
Change subject: Comment icon positioning
......................................................................
Comment icon positioning
* Tweak vertical position
* Add padding to make click target larger
* Add comment-in-heading test to demo
Change-Id: I7bf62e2f9422a2e6c1fdf7b1cfdcfa92e4642d61
---
M demos/ve/pages/comments.html
M modules/ve/ce/styles/nodes/ve.ce.CommentNode.css
2 files changed, 5 insertions(+), 4 deletions(-)
Approvals:
Trevor Parscal: Looks good to me, approved
jenkins-bot: Verified
diff --git a/demos/ve/pages/comments.html b/demos/ve/pages/comments.html
index 412b497..816bd27 100644
--- a/demos/ve/pages/comments.html
+++ b/demos/ve/pages/comments.html
@@ -14,7 +14,7 @@
<table><tr><td>Table 2</td></table>
<!-- after table 2 -->
Baz
-<p>Foo <!--
+<h2>Foo <!--
Block comment:
@@ -22,7 +22,7 @@
* Multiple
* Lines
---> Baz! Empty comment: <!----></p>
+--> Baz! Empty comment: <!----></h2>
<p><!-- Bar2 --></p>
<p>Lorem Ipsum is simply dummy text of the printing and typesetting industry.
Lorem Ipsum has been the industry's standard dummy text ever <!-- Bar3 -->
since the 1500s, when an unknown printer took a galley of type and scrambled it
to make a type specimen book. It has survived not only five centuries, but
<!--And this comment goes on forever to demonstrate that users won't see the
whole context, just the first few characters until they run out of room.-->also
the leap into electronic typesetting, remaining essentially unchanged.</p>
<p><b>Foo <!-- Bar4 --> Baz!</b></p>
diff --git a/modules/ve/ce/styles/nodes/ve.ce.CommentNode.css
b/modules/ve/ce/styles/nodes/ve.ce.CommentNode.css
index de0bd4d..f4b1a38 100644
--- a/modules/ve/ce/styles/nodes/ve.ce.CommentNode.css
+++ b/modules/ve/ce/styles/nodes/ve.ce.CommentNode.css
@@ -7,8 +7,9 @@
.ve-ce-commentNode {
display: inline-block;
- margin: 0 0.15em;
-
+ vertical-align: middle;
+ padding: 0.2em;
+ margin: -0.25em 0.15em 0 0.15em;
width: 1em;
height: 1em;
background-repeat: no-repeat;
--
To view, visit https://gerrit.wikimedia.org/r/150182
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7bf62e2f9422a2e6c1fdf7b1cfdcfa92e4642d61
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <esand...@wikimedia.org>
Gerrit-Reviewer: Trevor Parscal <tpars...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
